Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The command "seen" does not work as intended. #218

Open
sindastra opened this issue Jan 17, 2016 · 5 comments
Open

The command "seen" does not work as intended. #218

sindastra opened this issue Jan 17, 2016 · 5 comments

Comments

@sindastra
Copy link
Contributor

I have already fixed the issue and will make a pull request.

The command "seen" should allow you to check when a specified user has last said something in a specified channel.

Scenario
Check when a specified user has said something in a specified channel .

Test step
Enter .seen

Expected result
If was "seen" in , it should return when was last seen in .
If was never seen in , it should return that has never been seen in .

Actual outcome
It returns that it can't look up that name, because it's impossible to use.

sindastra added a commit to sindastra/CloudBot that referenced this issue Jan 17, 2016
Fixed regular expression
Fixed typo
Updated return messages to include the channel
@tuxxy
Copy link
Contributor

tuxxy commented Jun 13, 2016

It appears that the maintainers don't look after this project anymore and, as such, have stopped reviewing pull requests.
If you submit this to my fork, I'll go ahead and merge it.

https://github.com/tuxxy/CloudBot

@Red-M
Copy link
Contributor

Red-M commented Jun 14, 2016

In the sake of keeping the conversation in one stream please move it to PR #212

daboross pushed a commit that referenced this issue Jun 16, 2016
tuzonghua pushed a commit to tuzonghua/CloudBot that referenced this issue Jul 26, 2016
…ed return messages to include the channel
tuzonghua pushed a commit to tuzonghua/CloudBot that referenced this issue Jul 26, 2016
…ed return messages to include the channel
tuzonghua pushed a commit to tuzonghua/CloudBot that referenced this issue Jul 26, 2016
…ed return messages to include the channel
@whispy
Copy link

whispy commented Oct 4, 2016

Any updates on a fix for this?

@sindastra
Copy link
Contributor Author

Any updates on a fix for this?

@whispy #219 Fixed issue #218

I already fixed it. Look at my pull request.

@whispy
Copy link

whispy commented Oct 4, 2016

@sindastra The plugin crashes when I try to run it with your version.

Here's the traceback:

[16:13:37] [ERROR] Error loading history.py:
Traceback (most recent call last):
 File "/buttbot/plugin.py", line 147, in load_plugin
   plugin_module = importlib.import_module(module_name)
  File "/usr/lib/python3.5/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 986, in _gcd_import
  File "<frozen importlib._bootstrap>", line 969, in _find_and_load
  File "<frozen importlib._bootstrap>", line 958, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 673, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 661, in exec_module
  File "<frozen importlib._bootstrap_external>", line 767, in get_code
  File "<frozen importlib._bootstrap_external>", line 727, in source_to_code
  File "<frozen importlib._bootstrap>", line 222, in _call_with_frames_removed
  File "/plugins/history.py", line 125
    return "I've never seen {} talking in {}.".format(name, chan)
                                                                ^
IndentationError: expected an indented block

EDIT: Disregard the above. My file on the server wasn't synced and was missing indentation for the line specified in the traceback.

linuxdaemon pushed a commit to linuxdaemon/CloudBot that referenced this issue Nov 14, 2017
…-fix

Forgot to initialize the botwide observer
tuzonghua pushed a commit to tuzonghua/CloudBot that referenced this issue Nov 15, 2017
tuzonghua pushed a commit to tuzonghua/CloudBot that referenced this issue Nov 21, 2017
tuzonghua pushed a commit to tuzonghua/CloudBot that referenced this issue Nov 21, 2017
tuzonghua pushed a commit to tuzonghua/CloudBot that referenced this issue Nov 21, 2017
tuzonghua pushed a commit to tuzonghua/CloudBot that referenced this issue Nov 21, 2017
tuzonghua pushed a commit to tuzonghua/CloudBot that referenced this issue Nov 21, 2017
linuxdaemon added a commit to linuxdaemon/CloudBot that referenced this issue Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants