Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: additional node pool settings, single auto scaler profile and api server access #10

Closed
wants to merge 7 commits into from

Conversation

MDBeudekerCN
Copy link

@MDBeudekerCN MDBeudekerCN commented Jan 4, 2024

  • Added settings to node pools:
    os_disk_type
    os_disk_size_gb
    orchestrator_version

  • Added nodepool name, so existing node pools are not renamed to "aks-"

  • Changed auto scaler profile configuration since Terraform only allows one auto scaler profile

  • Changed linux-profile-admin variable definition

  • Changed oms.agent variable definition

  • added optional api_server_access_profile element

@MDBeudekerCN MDBeudekerCN requested a review from a team as a code owner January 4, 2024 15:37
@MDBeudekerCN
Copy link
Author

For the following two elements:

Changed linux-profile-admin variable definition
Changed oms.agent variable definition
I am unsure it it was a good idea to change these values to variables, but i would like to discuss on that

@MDBeudekerCN MDBeudekerCN changed the title feat: additional node pool settings, single auto scaler profile and api server access feat: additional node pool settings, single auto scaler profile and api server access Jan 4, 2024
@eddy-vera
Copy link

@MDBeudekerCN: Please raise separate issues and PR's for each issue/feature.
New default node pool properties have been split to this PR:
#13

Others will follow.

@dkooll
Copy link
Contributor

dkooll commented Jan 30, 2024

Seperate PR's are created. Closing this one.

@dkooll dkooll closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants