Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicitly set fallback values for ssh key and admin password #72

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

dkooll
Copy link
Contributor

@dkooll dkooll commented Jun 28, 2024

Description

This bug fix enables the generation of SSH keys or passwords directly from the module, as well as from the keyvault module, without errors. I added some documentation regarding the different authentication use cases for clarity as well.

PR Checklist

  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have made corresponding changes to the documentation
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking change (not backwards compatible with previous releases)

Related Issue(s)

Fixes #71

@dkooll dkooll added the bug Something isn't working label Jun 28, 2024
@dkooll dkooll self-assigned this Jun 28, 2024
@dkooll dkooll requested a review from a team as a code owner June 28, 2024 11:01
@dkooll dkooll added the documentation Improvements or additions to documentation label Jun 28, 2024
examples/authentication/main.tf Outdated Show resolved Hide resolved
examples/authentication/main.tf Outdated Show resolved Hide resolved
@dkooll dkooll merged commit a6f7c6e into main Jul 1, 2024
4 checks passed
@dkooll dkooll deleted the fix/fallback-values-ssh branch July 1, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

key does not identify an element in collection value when using byo authentication
2 participants