Skip to content

Commit

Permalink
feat!: aligned several properties and resources (#47)
Browse files Browse the repository at this point in the history
* feat!: aligned several properties and resources
BREAKING CHANGE: * data structure has changed due to renaming of properties and removal of resources.

* feat: fix linting issues

---------

Co-authored-by: dkool <dkool@dkools-MacBook-Pro.local>
  • Loading branch information
dkooll and dkool authored Sep 18, 2024
1 parent 099dcab commit f155777
Show file tree
Hide file tree
Showing 51 changed files with 194 additions and 1,839 deletions.
5 changes: 1 addition & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,4 @@
export TF_PATH

test:
cd tests && go test -v -timeout 60m -run TestApplyNoError/$(TF_PATH) ./virtualwan_test.go

#test_extended:
#cd tests && env go test -v -timeout 60m -run TestVm ./vm_extended_test.go
cd tests && go test -v -timeout 60m -run TestApplyNoError/$(TF_PATH) ./vwan_test.go
24 changes: 3 additions & 21 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,9 @@ End-to-end testing is not conducted on these modules, as they are individual com

## Features

- simplified virtual wan deployment across regions
- simplified virtual wan deployment
- multiple secure virtual hub support
- utilization of terratest for robust validation
- multiple collection groups, collections and rules support
- optional ip group integration in collection rule groups
- supports base and child policy inheritance

## Requirements

Expand All @@ -44,22 +41,10 @@ End-to-end testing is not conducted on these modules, as they are individual com
|------|---------|
| <a name="provider_azurerm"></a> [azurerm](#provider\_azurerm) | ~> 3.61 |

## Modules

| Name | Source |
|------|--------|
| [collection-rule-groups](./modules/collection-rule-groups) | resource |
| [firewall-policy](./modules/firewall-policy) | resource |

## Resources

| Name | Type |
|------|------|
| [azurerm_firewall](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/firewall) | resource |
| [azurerm_firewall_policy](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/firewall_policy) | resource |
| [azurerm_firewall_policy_rule_collection_group](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/firewall_policy_rule_collection_group) | resource |
| [azurerm_ip_group](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/ip_group) | resource |
| [azurerm_ip_group_cidr](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/ip_group_cidr) | resource |
| [azurerm_virtual_hub](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/virtual_hub) | resource |
| [azurerm_virtual_wan](https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/virtual_wan) | resource |

Expand All @@ -70,17 +55,14 @@ End-to-end testing is not conducted on these modules, as they are individual com
| `vwan` | describes virtual wan configuration | object | yes |
| `naming` | contains naming convention | string | yes |
| `location` | default azure region and can be used if location is not specified inside the object | string | no |
| `resourcegroup` | default resource group and can be used if resourcegroup is not specified inside the object | string | no |
| `resource_group` | default resource group and can be used if resourcegroup is not specified inside the object | string | no |

## Outputs

| Name | Description |
| :-- | :-- |
| `vwan` | contains virtual wan configuration |
| `policy` | contains firewall policy configuration |
| `vhub` | contains virtual hub configuration |
| `firewall` | contains firewall configuration |
| `firewall_public_ip_addresses` | list of public ip addresses associated with the firewall |
| `vhubs` | contains virtual hub configuration |

## Testing

Expand Down
122 changes: 0 additions & 122 deletions examples/collection-rule-groups/README.md

This file was deleted.

84 changes: 0 additions & 84 deletions examples/collection-rule-groups/locals.tf

This file was deleted.

53 changes: 0 additions & 53 deletions examples/collection-rule-groups/main.tf

This file was deleted.

14 changes: 0 additions & 14 deletions examples/collection-rule-groups/terraform.tf

This file was deleted.

27 changes: 11 additions & 16 deletions examples/default/README.md
Original file line number Diff line number Diff line change
@@ -1,20 +1,15 @@
This example illustrates the defaul tvirtual wan setup, in its simplest form.
# Default

## Usage
This example illustrates the default setup, in its simplest form.

```hcl
module "vwan" {
source = "cloudnationhq/vwan/azure"
version = "~> 0.11"
naming = local.naming
## Types

resourcegroup = module.rg.groups.demo.name
location = module.rg.groups.demo.location
vwan = {
allow_branch_to_branch_traffic = true
disable_vpn_encryption = false
}
}
```hcl
vwan = object({
name = string
resource_group = string
location = string
allow_branch_to_branch_traffic = optional(bool)
disable_vpn_encryption = optional(bool)
})
```
Loading

0 comments on commit f155777

Please sign in to comment.