Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix global tags and updated documentation #54

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

jasperpostcn
Copy link
Contributor

Description

  • Added possibility for generic tags for all resources created in the vwan module
  • Updated README with new azurerm version

PR Checklist

  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Changes to existing Resource / Data Source

  • I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
  • I have made corresponding changes to the documentation
  • I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
  • (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Change Log

  • Added possibility for generic tags for all resources created in the vwan module
  • Updated README with new azurerm version

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking change (not backwards compatible with previous releases)

@jasperpostcn jasperpostcn requested a review from a team as a code owner September 25, 2024 12:52
@dkooll dkooll changed the title fix: global tags for vwan resources fix: fix global tags and updated documentation Sep 25, 2024
Copy link
Contributor

@dkooll dkooll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dkooll dkooll merged commit 8da21d7 into main Sep 25, 2024
8 checks passed
@dkooll dkooll deleted the fix/global_tags branch September 25, 2024 12:56
@jasperpostcn jasperpostcn self-assigned this Oct 7, 2024
@jasperpostcn jasperpostcn added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants