Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add express route gateway support #69

Merged
merged 1 commit into from
Oct 31, 2024
Merged

feat: add express route gateway support #69

merged 1 commit into from
Oct 31, 2024

Conversation

dkooll
Copy link
Contributor

@dkooll dkooll commented Oct 31, 2024

Description

This PR adds express route gateway support on virtual hubs

PR Checklist

  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking change (not backwards compatible with previous releases)

Related Issue(s)

Fixes #58

@dkooll dkooll added the enhancement New feature or request label Oct 31, 2024
@dkooll dkooll self-assigned this Oct 31, 2024
@dkooll dkooll requested a review from a team as a code owner October 31, 2024 11:34
jasperpostcn
jasperpostcn approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@jasperpostcn jasperpostcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dkooll dkooll merged commit 4c3ebaf into main Oct 31, 2024
4 checks passed
@dkooll dkooll deleted the feat/add-expressroute-gw-support branch October 31, 2024 11:36
@release-please release-please bot mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasperpostcn jasperpostcn jasperpostcn approved these changes

Assignees

@dkooll dkooll

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add express route support
2 participants
@dkooll @jasperpostcn