Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner code only supports French VAT Numbers #11

Open
kevinobee opened this issue Nov 18, 2019 · 2 comments
Open

Cleaner code only supports French VAT Numbers #11

kevinobee opened this issue Nov 18, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@kevinobee
Copy link
Contributor

https://github.com/CluedIn-io/Enricher.VatLayer/blob/7b88da3d9aa1b33d16613b9a68bd46a7980abf93/src/Utility/VatNumberCleaner.cs#L20

@kevinobee kevinobee added the bug Something isn't working label Nov 18, 2019
@kevinobee
Copy link
Contributor Author

Tests added to branch https://github.com/CluedIn-io/Enricher.VatLayer/tree/bugfix/Only-French-Numbers-Are-Supported based on VAT numbers examples provided by ISS.

These tests show 89 failures when run.

@lovrobiljeskovic
Copy link
Contributor

@kevinobee I fixed this, I forgot to remove commented code for all the regex matchers for each country. I pushed the working commit. However we have 33 tests specifically for GB VAT numbers which still fail; this is due to the VAT numbers provided not matching any company. The VAT numbers themselves are in the proper format, but if they do not match any company according to the VatLayer API, the tests will fail.

I would assume that the VAT numbers which were provided by ISS are outdated/invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants