Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing exception handling in public methods #4

Open
kevinobee opened this issue Sep 21, 2019 · 0 comments
Open

Missing exception handling in public methods #4

kevinobee opened this issue Sep 21, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@kevinobee
Copy link
Contributor

https://github.com/CluedIn-io/Enricher.VatLayer/blob/ae711603e9664cc54e650a1cdb6b33e6db571697/src/VatLayerExternalSearchProvider.cs#L69

Exception handling try .. catch blocks are missing from public methods called by the CluedIn server framework.

Consider adding:

  • Add try .. catch exception handling in public methods where service boundaries are crossed

  • Add logging in catch handling blocks to raise Error level log events
@kevinobee kevinobee added the enhancement New feature or request label Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevinobee