Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing invalid data response handling logic #5

Open
kevinobee opened this issue Sep 21, 2019 · 0 comments
Open

Missing invalid data response handling logic #5

kevinobee opened this issue Sep 21, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@kevinobee
Copy link
Contributor

https://github.com/CluedIn-io/Enricher.VatLayer/blob/ae711603e9664cc54e650a1cdb6b33e6db571697/src/VatLayerExternalSearchProvider.cs#L109

Missing else block to handle successful calls to client.ExecuteTaskAsync<VatLayerResponse>(request) that return invalid data.

Failure paths in public methods should either throw an exception or return an error result. In both cases the failure condition should be logged.

@kevinobee kevinobee added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant