Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some mods are slowing down CBA XEHs #4

Open
freghar opened this issue Jan 21, 2021 · 6 comments
Open

Some mods are slowing down CBA XEHs #4

freghar opened this issue Jan 21, 2021 · 6 comments
Labels
Bug Existing feature that doesn't work as intended

Comments

@freghar
Copy link
Collaborator

freghar commented Jan 21, 2021

WARNING: Car does not support Extended Event Handlers! Addon: @project_opfor
WARNING: Tank does not support Extended Event Handlers! Addon: @acre2
WARNING: Air does not support Extended Event Handlers! Addon: @ace
WARNING: TH_SNOWING1 does not support Extended Event Handlers! Addon: @thirsk
WARNING: TH_SNOWING2 does not support Extended Event Handlers! Addon: @thirsk
WARNING: TH_SNOWING3 does not support Extended Event Handlers! Addon: @thirsk
WARNING: TH_SNOWING4 does not support Extended Event Handlers! Addon: @thirsk
WARNING: TH_FOG1 does not support Extended Event Handlers! Addon: @thirsk
WARNING: TH_FOG2 does not support Extended Event Handlers! Addon: @thirsk
WARNING: TH_FOG3 does not support Extended Event Handlers! Addon: @thirsk
WARNING: TH_SNOWSTORM1 does not support Extended Event Handlers! Addon: @thirsk
WARNING: Ryanzombieslogiceasy does not support Extended Event Handlers! Addon: @zombies_and_demons
WARNING: Ryanzombieslogicspawnfast1opfor does not support Extended Event Handlers! Addon: @zombies_and_demons
WARNING: RyanZombieCivilian_F does not support Extended Event Handlers! Addon: @zombies_and_demons
WARNING: RyanZombieB_Soldier_base_F does not support Extended Event Handlers! Addon: @zombies_and_demons
WARNING: RyanZombiePlayer1 does not support Extended Event Handlers! Addon: @zombies_and_demons
WARNING: I_E_Soldier_F_OCimport_01 does not support Extended Event Handlers! Addon: @jfo_park_rangers
WARNING: I_E_Soldier_TL_F_OCimport_01 does not support Extended Event Handlers! Addon: @jfo_park_rangers
WARNING: I_E_soldier_M_F_OCimport_01 does not support Extended Event Handlers! Addon: @jfo_park_rangers
WARNING: I_E_Survivor_F_OCimport_01 does not support Extended Event Handlers! Addon: @jfo_park_rangers
WARNING: I_E_Medic_F_OCimport_01 does not support Extended Event Handlers! Addon: @jfo_park_rangers
WARNING: I_E_Quadbike_01_F_OCimport_01 does not support Extended Event Handlers! Addon: @jfo_park_rangers
WARNING: I_E_Offroad_01_F_OCimport_01 does not support Extended Event Handlers! Addon: @jfo_park_rangers
WARNING: I_E_Offroad_01_covered_F_OCimport_01 does not support Extended Event Handlers! Addon: @jfo_park_rangers
WARNING: I_E_Offroad_01_comms_F_OCimport_01 does not support Extended Event Handlers! Addon: @jfo_park_rangers
WARNING: I_E_Van_02_vehicle_F_OCimport_01 does not support Extended Event Handlers! Addon: @jfo_park_rangers
WARNING: I_E_Van_02_medevac_F_OCimport_01 does not support Extended Event Handlers! Addon: @jfo_park_rangers
...
WARNING: One or more children of class CAManBase do not support Extended Event Handlers. Fall back to loop.

Now, the list of related mods is probably not 100% correct.

  • Car/Tank/Air are broken by something called babe_int_EHs (nice) which comes from @enhanced_movement
    • It would seem the mod deletes / overrides the class EventHandlers { ... } set up by CBA
  • TH_* is indeed @thirsk
    • Thirsk sets up its own init = "[_this select 0,4] exec ""\RHNET\Thirsk5\scripts\THIRSK_Snow.sqs""";, overriding / not caring for the CBA one
  • Ryanzombies* is obviously @zombies_and_demons
    • This is an attempt at a good definition, class CBA_Extended_EventHandlers {};, but lacks the inheritance of CBA_..._base as needed by CBA XEHs
  • The rest is correctly @jfo_park_rangers and it seems to deliberately define empty class EventHandlers {};, overwriting what CBA set up for the parent class(es)

Now, it says the issue is really only with CAManBase, but since @enhanced_movement essentially removed CBA's ability to watch EHs for Car, Tank and Air, some pretty common names people use for CBA class event handlers, I'm afraid we need to fix/report/both all of them to stop CBA from looping.

@freghar
Copy link
Collaborator Author

freghar commented Jan 21, 2021

@enhanced_movement submitted as SceptreOfficial/Enhanced-Movement-Rework#12

@freghar
Copy link
Collaborator Author

freghar commented Jan 22, 2021

@JamesTheClarke Heya, do you still plan to remove @jfo_park_rangers (in the future) as was mentioned on the January MMT meeting? I don't see it mentioned anywhere aside from the meeting notes, so just confirming. Thanks!

@freghar
Copy link
Collaborator Author

freghar commented Jan 24, 2021

I would like to keep this open until

  • Enhanced Movement Rework is updated on steam and we pull it via a repo update
  • we remove JFO park rangers

in order to verify that the warnings are gone.

@freghar freghar reopened this Jan 24, 2021
@milivojm milivojm added the Bug Existing feature that doesn't work as intended label Feb 4, 2021
@JamesTheClarke
Copy link

JamesTheClarke commented Feb 17, 2021

Both JFO mods have been removed from our Main Repository: https://www.carpenoctem.co/forums/m/26081621/viewthread/16086660-a3sync-repository-status/post/139466358#p139466358

Please test again and close this issue if the remaining mods (Zombies and Thirsk) are not causing overtly problematic performance issues. Otherwise, we might want to start a Staff Forum discussion on removing these mods if they can't be fixed/made compatible with ACE3 damage handlers.

@JamesTheClarke
Copy link

@freghar can this issue be closed or are there further adjustments we should make on the server/repo?

@freghar
Copy link
Collaborator Author

freghar commented Mar 26, 2021

The errors pointing out specific mods are gone, but

WARNING: One or more children of class CAManBase do not support Extended Event Handlers. Fall back to loop.

still remains.

Somebody need to (1) fidn out which mod is causing it by starting the game with some mods "unticked" and (2) figure out what exactly is CBA checking for. Then we can perhaps finally fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Existing feature that doesn't work as intended
Projects
None yet
Development

No branches or pull requests

3 participants