Skip to content

Commit

Permalink
fix: onEvent must liten at the document level, if no value allow coma…
Browse files Browse the repository at this point in the history
…parion of if esle conditions
  • Loading branch information
frankpagan committed May 5, 2024
1 parent 0d8db13 commit 57d1f91
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -233,10 +233,10 @@ const CoCreateEvents = {
if (onEvent) {
await new Promise((resolve, reject) => {
const handleEvent = () => {
element.removeEventListener(onEvent, handleEvent);
document.removeEventListener(onEvent, handleEvent);
resolve();
};
element.addEventListener(onEvent, handleEvent);
document.addEventListener(onEvent, handleEvent);
});
}

Expand All @@ -250,7 +250,9 @@ const CoCreateEvents = {
if (values)
localStorage.setItem(key, values)
}
if (!key || !values)

// if (!key || !values)
if (!key)
return
} else {
values = element.getAttribute(`${prefix}-value`) || element.getAttribute(`${prefix}-if-value`) || element.getAttribute(prefix);
Expand All @@ -275,7 +277,7 @@ const CoCreateEvents = {

let ifValue = element.getAttribute(`${prefix}-if-value`)
if (!ifValue && ifValue !== "")
ifValue = await element.getValue()
ifValue = values // await element.getValue()
else if (ifValue || ifValue === "")
ifValue = [ifValue]
else
Expand Down

0 comments on commit 57d1f91

Please sign in to comment.