This repository has been archived by the owner on Aug 26, 2021. It is now read-only.
Finish partially implemented don't stop on error feature #22
Labels
enhancement
New feature or request
Milestone
Comments
Cobular
added a commit
that referenced
this issue
Sep 20, 2019
…21) * Need to prod github into letting me make a PR * Initialized the sphinx documentation, currently ignoring the build directory * Added documentation for `__init__.py`'s methods Added some docstrings, setup the rst to autogenerate based on those docstrings * Prepped the docs files for the other files Still have to implement autodoc and improve the documentation for these * Heavily improved the documentation for bot.py, bot.rst bow autogenerates the correct documentation I also made some very small changes to some other files and to the sphinx config * Documented collector.py, got intersphinx working * Added a dev requirements, added a few more pages, added the toctree, Also fixed some issues in the docstrings * Makefile is now system-agnostic (needs active venv) * slowly and steadily, documentation is coming along * Removed 4 TODOs, details below __init__.py ~124: Made issue #23 covering the TODO __init__.py ~145: Fixed small error in intersphinx link in `collector.py` bot.py ~72: Made issue #22 covering the TODO bot.py ~102: Made issue #24, should be ez to fix * implement timeout in DiscordInteractiveInterface. Just one line. * Got quickstart done. finally getting the hang of rst syntax * prettier and clearer. * Quickstart looks great! Added a bit, tried to make the interface docs more clear I'm writing this on a long plane ride (again lol) so this might mostly be trash, I will try to review this again when I get back to internet and am less of a tired mess. Really great job on the quickstart! I might just leave this for you to do from now on though since you have a batter grasp on rst than me, if you're fine with that, we can chat on discord about it if you want. * Working on creating ci testing for the documentation * Updated travis.yml to include the sphinx test, let's see how this goes * Fixing issues in travis.yml * Pulled the remaining todos, they were not really necessary (thanks tired plane me) * Remove extraneous words and stuff. Let me know if there are any issues with this, if not I'll do the same sort of thing with all/most of the other pages in the coming days.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This is handled in the
run_testfunction in theDiscordBotclass, but thestop_errorbool is never implemented by any tests. See below for it's current implementation, it basically suppresses the error.https://github.com/JakeCover/distest/blob/c1d8de0be5ccb972775e4e5e0c125798bfc75f71/distest/bot.py#L41-L44
I haven't thought this through much yet, but it seems like all we need to do is:
continue-past-errorvarriable all the way to when a test is run)Notes: brought up when documenting for #21, possible 1.1 item
The text was updated successfully, but these errors were encountered: