Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(criterion): allow explicit lifetime usage with compat #22

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

art049
Copy link
Member

@art049 art049 commented Oct 19, 2023

Fixes #13

@art049 art049 changed the base branch from chore/bump-rust-toolchain to main October 19, 2023 14:17
@art049 art049 force-pushed the feat/support-explcit-lifetimes branch from d947296 to dd3763f Compare October 19, 2023 14:18
@codspeed-hq
Copy link

codspeed-hq bot commented Oct 19, 2023

CodSpeed Performance Report

Merging #22 will degrade performances by 3.81%

Comparing feat/support-explcit-lifetimes (dd3763f) with main (40f11b2)

Summary

❌ 1 (👁 1) regressions
✅ 53 untouched benchmarks

🆕 1 new benchmarks

Benchmarks breakdown

Benchmark main feat/support-explcit-lifetimes Change
🆕 with_input[5] N/A 0 s N/A
👁 Flat 700.6 ns 728.3 ns -3.81%

@art049 art049 merged commit dd3763f into main Oct 19, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic parameters on Bencher are not API compatible with criterion
1 participant