Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cargo-codspeed): build all benches in a single cargo build #34

Merged
merged 3 commits into from
Feb 10, 2024

Conversation

adriencaccia
Copy link
Member

As pointed out by @Boshen in oxc-project/oxc#2343, we can build all the benches in a single command.

Copy link

codspeed-hq bot commented Feb 9, 2024

CodSpeed Performance Report

Merging #34 will improve performances by 14.2%

Comparing feat/single-build (69c8309) with main (fc75139)

Summary

⚡ 3 improvements
✅ 54 untouched benchmarks

Benchmarks breakdown

Benchmark main feat/single-build Change
Auto 223.3 ns 195.6 ns +14.2%
Linear 223.3 ns 195.6 ns +14.2%
Flat 728.3 ns 700.6 ns +3.97%

crates/cargo-codspeed/src/prelude.rs Outdated Show resolved Hide resolved
rust-toolchain.toml Outdated Show resolved Hide resolved
@adriencaccia
Copy link
Member Author

@art049 I made the changes, let me know if it's okay to merge. I don't really know what to make of the performance improvements of the criterion sampling modes benchmarks.

@art049
Copy link
Member

art049 commented Feb 10, 2024

LGTM, @adriencaccia; those benches are relying on sleep. Thus we end up with syscall variance.

@adriencaccia adriencaccia merged commit 69c8309 into main Feb 10, 2024
4 checks passed
@adriencaccia adriencaccia deleted the feat/single-build branch February 10, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants