-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: add warmup runs #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
art049
commented
Jul 4, 2023
•
edited
Loading
edited
- Fix optimized out benches:
- Recursive
- Recursive[20]
- Recursive[21]
CodSpeed Performance ReportMerging #5 will improve performances by 83.64%Comparing Summary
Benchmarks breakdown
|
bors bot
referenced
this pull request
in evenfurther/pathfinding
Sep 22, 2023
440: chore(deps): update pre-commit/action action to v3 r=samueltardieu a=renovate[bot] [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pre-commit/action](https://togithub.com/pre-commit/action) | action | major | `v2.0.3` -> `v3.0.0` | --- ### Release Notes <details> <summary>pre-commit/action (pre-commit/action)</summary> ### [`v3.0.0`](https://togithub.com/pre-commit/action/releases/tag/v3.0.0): pre-commit/action@v3.0.0 [Compare Source](https://togithub.com/pre-commit/action/compare/v2.0.3...v3.0.0) ##### Breaking - remove pushing behaviour. - PR [#​164](https://togithub.com/pre-commit/action/issues/164) by [`@​asottile](https://togithub.com/asottile).` see [README] for alternatives [README]: https://togithub.com/pre-commit/action#using-this-action-in-private-repositories </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/samueltardieu/pathfinding). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ny4xIiwidXBkYXRlZEluVmVyIjoiMzYuOTcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> 443: chore(deps): update rust crate codspeed-criterion-compat to v2 r=samueltardieu a=renovate[bot] [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [codspeed-criterion-compat](https://codspeed.io) ([source](https://togithub.com/CodSpeedHQ/codspeed-rust)) | dev-dependencies | major | `1.1.0` -> `2.2.0` | --- ### Release Notes <details> <summary>CodSpeedHQ/codspeed-rust (codspeed-criterion-compat)</summary> ### [`v2.2.0`](https://togithub.com/CodSpeedHQ/codspeed-rust/releases/tag/v2.2.0) [Compare Source](https://togithub.com/CodSpeedHQ/codspeed-rust/compare/v2.1.0...v2.2.0) #### What's Changed It's now possible to disable `codspeed_criterion_compat` default features. ##### Details - fix: allow disabling criterion default features by [`@​art049](https://togithub.com/art049)` in [https://github.com/CodSpeedHQ/codspeed-rust/pull/12](https://togithub.com/CodSpeedHQ/codspeed-rust/pull/12) **Full Changelog**: CodSpeedHQ/codspeed-rust@v2.1.0...v2.2.0 ### [`v2.1.0`](https://togithub.com/CodSpeedHQ/codspeed-rust/releases/tag/v2.1.0) [Compare Source](https://togithub.com/CodSpeedHQ/codspeed-rust/compare/v2.0.0...v2.1.0) #### 🎉 What's Changed - Relative paths are now properly handled when using the `working-directory` action parameter. #### 📚 Details - fix: fix relative path when using working-directory by [`@​art049](https://togithub.com/art049)` in [https://github.com/CodSpeedHQ/codspeed-rust/pull/9](https://togithub.com/CodSpeedHQ/codspeed-rust/pull/9) **Full Changelog**: CodSpeedHQ/codspeed-rust@v2.0.0...v2.1.0 ### [`v2.0.0`](https://togithub.com/CodSpeedHQ/codspeed-rust/releases/tag/v2.0.0) [Compare Source](https://togithub.com/CodSpeedHQ/codspeed-rust/compare/codspeed-criterion-compat@1.1.0...v2.0.0) #### 🎉 What's Changed - Each benchmark is warmed up before each run to reduce the flakiness and the side effects related to the order in which the benchmarks are run. - `AsyncBencher` is now supported with the `criterion` compatibility layer. - Debug symbols are now generated during the build of the benchmarks, allowing more granularity in the performance reports and detailed profiling. More details can be found in [the documentation](https://docs.codspeed.io/features/trace-generation). #### 🚀 Migration Path This is a **breaking change** and might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🎉! In some cases, the warmup might optimize out the benchmark. In that case, adding `black_box` should help, also don't hesitate to open an issue so we can have a look and document the behavior. We recommend you create a standalone PR to update the package, acknowledge the potential regressions, and merge it to update the baseline on your default branch. #### 📚 Details ##### Features - feat: add debug symbols in the benchmark build config by [`@​art049](https://togithub.com/art049)` in [https://github.com/CodSpeedHQ/codspeed-rust/pull/4](https://togithub.com/CodSpeedHQ/codspeed-rust/pull/4) - feat: add AsyncBencher support by [`@​art049](https://togithub.com/art049)` in [https://github.com/CodSpeedHQ/codspeed-rust/pull/7](https://togithub.com/CodSpeedHQ/codspeed-rust/pull/7) - feat!: add warmup runs by [`@​art049](https://togithub.com/art049)` in [https://github.com/CodSpeedHQ/codspeed-rust/pull/5](https://togithub.com/CodSpeedHQ/codspeed-rust/pull/5) ##### Internals - chore: bump criterion by [`@​art049](https://togithub.com/art049)` in [https://github.com/CodSpeedHQ/codspeed-rust/pull/8](https://togithub.com/CodSpeedHQ/codspeed-rust/pull/8) **Full Changelog**: CodSpeedHQ/codspeed-rust@v1.1.0...v2.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/samueltardieu/pathfinding). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ny4xIiwidXBkYXRlZEluVmVyIjoiMzYuOTcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
bors bot
referenced
this pull request
in evenfurther/pathfinding
Sep 22, 2023
443: chore(deps): update rust crate codspeed-criterion-compat to v2 r=samueltardieu a=renovate[bot] [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [codspeed-criterion-compat](https://codspeed.io) ([source](https://togithub.com/CodSpeedHQ/codspeed-rust)) | dev-dependencies | major | `1.1.0` -> `2.2.0` | --- ### Release Notes <details> <summary>CodSpeedHQ/codspeed-rust (codspeed-criterion-compat)</summary> ### [`v2.2.0`](https://togithub.com/CodSpeedHQ/codspeed-rust/releases/tag/v2.2.0) [Compare Source](https://togithub.com/CodSpeedHQ/codspeed-rust/compare/v2.1.0...v2.2.0) #### What's Changed It's now possible to disable `codspeed_criterion_compat` default features. ##### Details - fix: allow disabling criterion default features by [`@​art049](https://togithub.com/art049)` in [https://github.com/CodSpeedHQ/codspeed-rust/pull/12](https://togithub.com/CodSpeedHQ/codspeed-rust/pull/12) **Full Changelog**: CodSpeedHQ/codspeed-rust@v2.1.0...v2.2.0 ### [`v2.1.0`](https://togithub.com/CodSpeedHQ/codspeed-rust/releases/tag/v2.1.0) [Compare Source](https://togithub.com/CodSpeedHQ/codspeed-rust/compare/v2.0.0...v2.1.0) #### 🎉 What's Changed - Relative paths are now properly handled when using the `working-directory` action parameter. #### 📚 Details - fix: fix relative path when using working-directory by [`@​art049](https://togithub.com/art049)` in [https://github.com/CodSpeedHQ/codspeed-rust/pull/9](https://togithub.com/CodSpeedHQ/codspeed-rust/pull/9) **Full Changelog**: CodSpeedHQ/codspeed-rust@v2.0.0...v2.1.0 ### [`v2.0.0`](https://togithub.com/CodSpeedHQ/codspeed-rust/releases/tag/v2.0.0) [Compare Source](https://togithub.com/CodSpeedHQ/codspeed-rust/compare/codspeed-criterion-compat@1.1.0...v2.0.0) #### 🎉 What's Changed - Each benchmark is warmed up before each run to reduce the flakiness and the side effects related to the order in which the benchmarks are run. - `AsyncBencher` is now supported with the `criterion` compatibility layer. - Debug symbols are now generated during the build of the benchmarks, allowing more granularity in the performance reports and detailed profiling. More details can be found in [the documentation](https://docs.codspeed.io/features/trace-generation). #### 🚀 Migration Path This is a **breaking change** and might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🎉! In some cases, the warmup might optimize out the benchmark. In that case, adding `black_box` should help, also don't hesitate to open an issue so we can have a look and document the behavior. We recommend you create a standalone PR to update the package, acknowledge the potential regressions, and merge it to update the baseline on your default branch. #### 📚 Details ##### Features - feat: add debug symbols in the benchmark build config by [`@​art049](https://togithub.com/art049)` in [https://github.com/CodSpeedHQ/codspeed-rust/pull/4](https://togithub.com/CodSpeedHQ/codspeed-rust/pull/4) - feat: add AsyncBencher support by [`@​art049](https://togithub.com/art049)` in [https://github.com/CodSpeedHQ/codspeed-rust/pull/7](https://togithub.com/CodSpeedHQ/codspeed-rust/pull/7) - feat!: add warmup runs by [`@​art049](https://togithub.com/art049)` in [https://github.com/CodSpeedHQ/codspeed-rust/pull/5](https://togithub.com/CodSpeedHQ/codspeed-rust/pull/5) ##### Internals - chore: bump criterion by [`@​art049](https://togithub.com/art049)` in [https://github.com/CodSpeedHQ/codspeed-rust/pull/8](https://togithub.com/CodSpeedHQ/codspeed-rust/pull/8) **Full Changelog**: CodSpeedHQ/codspeed-rust@v1.1.0...v2.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/samueltardieu/pathfinding). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ny4xIiwidXBkYXRlZEluVmVyIjoiMzYuOTcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
bors bot
referenced
this pull request
in evenfurther/pathfinding
Sep 22, 2023
443: chore(deps): update rust crate codspeed-criterion-compat to v2 r=samueltardieu a=renovate[bot] [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [codspeed-criterion-compat](https://codspeed.io) ([source](https://togithub.com/CodSpeedHQ/codspeed-rust)) | dev-dependencies | major | `1.1.0` -> `2.2.0` | --- ### Release Notes <details> <summary>CodSpeedHQ/codspeed-rust (codspeed-criterion-compat)</summary> ### [`v2.2.0`](https://togithub.com/CodSpeedHQ/codspeed-rust/releases/tag/v2.2.0) [Compare Source](https://togithub.com/CodSpeedHQ/codspeed-rust/compare/v2.1.0...v2.2.0) #### What's Changed It's now possible to disable `codspeed_criterion_compat` default features. ##### Details - fix: allow disabling criterion default features by [`@​art049](https://togithub.com/art049)` in [https://github.com/CodSpeedHQ/codspeed-rust/pull/12](https://togithub.com/CodSpeedHQ/codspeed-rust/pull/12) **Full Changelog**: CodSpeedHQ/codspeed-rust@v2.1.0...v2.2.0 ### [`v2.1.0`](https://togithub.com/CodSpeedHQ/codspeed-rust/releases/tag/v2.1.0) [Compare Source](https://togithub.com/CodSpeedHQ/codspeed-rust/compare/v2.0.0...v2.1.0) #### 🎉 What's Changed - Relative paths are now properly handled when using the `working-directory` action parameter. #### 📚 Details - fix: fix relative path when using working-directory by [`@​art049](https://togithub.com/art049)` in [https://github.com/CodSpeedHQ/codspeed-rust/pull/9](https://togithub.com/CodSpeedHQ/codspeed-rust/pull/9) **Full Changelog**: CodSpeedHQ/codspeed-rust@v2.0.0...v2.1.0 ### [`v2.0.0`](https://togithub.com/CodSpeedHQ/codspeed-rust/releases/tag/v2.0.0) [Compare Source](https://togithub.com/CodSpeedHQ/codspeed-rust/compare/codspeed-criterion-compat@1.1.0...v2.0.0) #### 🎉 What's Changed - Each benchmark is warmed up before each run to reduce the flakiness and the side effects related to the order in which the benchmarks are run. - `AsyncBencher` is now supported with the `criterion` compatibility layer. - Debug symbols are now generated during the build of the benchmarks, allowing more granularity in the performance reports and detailed profiling. More details can be found in [the documentation](https://docs.codspeed.io/features/trace-generation). #### 🚀 Migration Path This is a **breaking change** and might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🎉! In some cases, the warmup might optimize out the benchmark. In that case, adding `black_box` should help, also don't hesitate to open an issue so we can have a look and document the behavior. We recommend you create a standalone PR to update the package, acknowledge the potential regressions, and merge it to update the baseline on your default branch. #### 📚 Details ##### Features - feat: add debug symbols in the benchmark build config by [`@​art049](https://togithub.com/art049)` in [https://github.com/CodSpeedHQ/codspeed-rust/pull/4](https://togithub.com/CodSpeedHQ/codspeed-rust/pull/4) - feat: add AsyncBencher support by [`@​art049](https://togithub.com/art049)` in [https://github.com/CodSpeedHQ/codspeed-rust/pull/7](https://togithub.com/CodSpeedHQ/codspeed-rust/pull/7) - feat!: add warmup runs by [`@​art049](https://togithub.com/art049)` in [https://github.com/CodSpeedHQ/codspeed-rust/pull/5](https://togithub.com/CodSpeedHQ/codspeed-rust/pull/5) ##### Internals - chore: bump criterion by [`@​art049](https://togithub.com/art049)` in [https://github.com/CodSpeedHQ/codspeed-rust/pull/8](https://togithub.com/CodSpeedHQ/codspeed-rust/pull/8) **Full Changelog**: CodSpeedHQ/codspeed-rust@v1.1.0...v2.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/samueltardieu/pathfinding). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ny4xIiwidXBkYXRlZEluVmVyIjoiMzYuOTcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.