Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed 3338 #109

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixed 3338 #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions lapce-app/src/panel/terminal_view.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,6 @@ fn terminal_tab_split(
let internal_command = terminal_panel_data.common.internal_command;
let workspace = terminal_panel_data.workspace.clone();
let active = terminal_tab_data.active;
let terminal_tab_scope = terminal_tab_data.scope;
dyn_stack(
move || {
let terminals = terminal_tab_data.terminals.get();
Expand All @@ -279,7 +278,6 @@ fn terminal_tab_split(
|(_, terminal)| terminal.term_id,
move |(index, terminal)| {
let terminal_panel_data = terminal_panel_data.clone();
let terminal_scope = terminal.scope;
container({
let terminal_view = terminal_view(
terminal.term_id,
Expand Down Expand Up @@ -312,9 +310,6 @@ fn terminal_tab_split(
EventPropagation::Continue
}
})
.on_cleanup(move || {
terminal_scope.dispose();
})
.style(|s| s.size_pct(100.0, 100.0))
})
.style(move |s| {
Expand All @@ -329,10 +324,8 @@ fn terminal_tab_split(
})
},
)
.on_cleanup(move || {
terminal_tab_scope.dispose();
})
.style(|s| s.size_pct(100.0, 100.0))
.debug_name("terminal_tab_split")
}

fn terminal_tab_content(window_tab_data: Rc<WindowTabData>) -> impl View {
Expand All @@ -346,6 +339,7 @@ fn terminal_tab_content(window_tab_data: Rc<WindowTabData>) -> impl View {
},
)
.style(|s| s.size_pct(100.0, 100.0))
.debug_name("terminal_tab_content")
}

fn tab_secondary_click(
Expand Down
6 changes: 0 additions & 6 deletions lapce-app/src/terminal/view.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,12 +479,6 @@ impl TerminalView {
}
}

impl Drop for TerminalView {
fn drop(&mut self) {
self.proxy.terminal_close(self.term_id);
}
}

impl View for TerminalView {
fn id(&self) -> ViewId {
self.id
Expand Down
Loading