Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timesheet API: Data Validation for updateTimesheets endpoint #33

Open
3 tasks
izzyconner opened this issue May 12, 2023 · 0 comments
Open
3 tasks

Timesheet API: Data Validation for updateTimesheets endpoint #33

izzyconner opened this issue May 12, 2023 · 0 comments

Comments

@izzyconner
Copy link
Collaborator

izzyconner commented May 12, 2023

This serves as a clean-up for any and all data validation we need for admin, supervisor, and associate updateTimesheet endpoint(s)

  • Add in an editing lock system that will write in a userId when a timesheet is being edited by a certain role/user, and will prevent others from editing while it's locked
  • Only allow whitelisted attributes to be modified from the timesheet - they should not be able to overwrite certain fields such as the timesheetID, the startDate, etc.
  • For Associate Supervisor and Admin fields, they should only be able to update these attributes if they are the relevant person for each. I.e. Associate should only be modified if they are the employee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant