Save reports #16
Open
Save reports #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed package to allow for running backend and frontend in parallel
Added pre commit prettier hook
Co-authored-by: Rachel Ma <ma.ra@northeastern.edu>
Implemented submit card hookup and global user context
…into save-reports
izzyconner
requested changes
Apr 15, 2024
| @@ -29,6 +35,19 @@ export const CommentSchema = z.object({ | |||
|
|
|||
| export type CommentSchema = z.infer<typeof CommentSchema>; | |||
|
|
|||
| export const ReportSchema = z.object({ | |||
There was a problem hiding this comment.
I think we should also have a UUID field in the report schema as well - it's an easy way to have a unique identifier for each comment/report. Otherwise, looks good!
| getAllActiveCommentsOfType(CommentType.Report, comments).map((comment) => ({ | ||
| AuthorID: comment.AuthorID, | ||
| Type: comment.Type, | ||
| Content: comment.Content.split(",")[0], |
There was a problem hiding this comment.
I'd be careful using ',' as a delimiter here, since it wouldn't surprise me for the Explanation to include commas. Could you use something less frequently use to join and split the content, even just a semi-colon?
| AuthorID: report.AuthorID, | ||
| Type: report.Type, | ||
| Timestamp: report.Timestamp, | ||
| Content: `${report.Content},${report.Notified},${report.Explanation}`, |
There was a problem hiding this comment.
is there a reason why we need to try and turn reports into comments? Can we just fully separate out the reports and comments in the fields?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files changed:
apps/backend/src/db/timesheets/EntryOperations.ts
apps/frontend/src/components/TimeCardPage/CellTypes/CommentCell.tsx
apps/frontend/src/components/TimeCardPage/CellTypes/CommentModals/ShowReportModal.tsx
apps/frontend/src/components/TimeCardPage/TimeTableRow.tsx