Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ojn02/feat sign in error handling #56

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Ojn02/feat sign in error handling #56

wants to merge 3 commits into from

Conversation

ojn03
Copy link

@ojn03 ojn03 commented Mar 10, 2024

ℹ️ Issue

Closes #39

📝 Description

Ensured verify/sign-in endpoints worked, and properly relayed errors to the user

Briefly list the changes made to the code:

  • throw and catch exceptions on error
  • edited aws cognito settings to use a verification code rather than link

✔️ Verification

Tested with postman

chromium-52
chromium-52 reviewed Mar 19, 2024
View reviewed changes
Copy link
Member

@chromium-52 chromium-52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple questions but great work on this!

apps/backend/src/auth/auth.service.ts Show resolved Hide resolved
apps/backend/src/auth/auth.service.ts Show resolved Hide resolved
apps/backend/src/auth/auth.controller.ts Show resolved Hide resolved
apps/backend/src/auth/auth.controller.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chromium-52 chromium-52 chromium-52 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cognito] Add error handling to verify endpoint
2 participants
@ojn03 @chromium-52