Ahnfikd7/create accept reject endpoint #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-52
reviewed
Mar 19, 2024
| } | ||
|
|
||
| //Check if the string decision matches with the Decision enum | ||
| const decisionEnum: Decision = Decision[decision as keyof typeof Decision]; |
There was a problem hiding this comment.
❓We definitely need to make sure that the decision we get is a valid Decision but I think line 46 in this file (where we type the decision parameter) tells Nest to check this for us and throw an error if the type doesn't match. Can you try commenting out this check and passing in an invalid value as the decision and see if the endpoint still responds with a 400 Bad Request error?
There was a problem hiding this comment.
⛏️A potentially better alternative altogether is to make an application decision dto whose fields are applicantId and decision. Then, you can add decorators from class-validator such as @IsEnum(Decision) to the fields to ensure that Nest performs type checks at runtime.
kimharr24
reviewed
Mar 21, 2024
chromium-52
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #22
📝 Description
Wrote a new function processDecision inside applications.service that updates the application stage of an applicant to the next stage or to rejected.
In the decision endpoint inside the applications.controller, it delegates the decision making to service i.e processDecision.