Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lp gib 21 sign up frontend #14

Merged
merged 9 commits into from
Apr 18, 2024
Merged

Lp gib 21 sign up frontend #14

merged 9 commits into from
Apr 18, 2024

Conversation

lphan48
Copy link

@lphan48 lphan48 commented Mar 25, 2024

ℹ️ Issue

Closes #81

📝 Description

Created signup page and changed popup boxes to match the figma.

Changes:

  1. Created SignupPage component that appears when clicking on the popup box link
  2. Updated map PopupBox to match figma design

✔️ Verification

Screenshot 2024-03-25 at 12 53 32 PM Screenshot 2024-03-25 at 12 53 55 PM Screenshot 2024-03-25 at 12 54 11 PM

🏕️ Future Work / Notes

  1. Wasn't sure when the popupbox should be green or yellow, right now they're just green
  2. Didn't link the signup page to the signup button in the navbar because it wasn't merged yet

@lphan48 lphan48 self-assigned this Mar 25, 2024
width: '107px',
},
{
fields: [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the design team wanted to remove this field.

Welcome, Volunteer!
</Text>
</Box>
<Box className="input-fields-main" width="90%" mt="20px">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be great if we could add a close button and a submit button as well! I don't think it was the design but probably good to add. You don't have to implement the functionality for submit right now.

Copy link

@hams7504 hams7504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks for the changes

@mahekagg mahekagg merged commit aab41fa into main Apr 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants