Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add maintenance checklist popup #28

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ItsEricSun
Copy link

ℹ️ Issue

Closes https://www.notion.so/mahekagg/Add-Maintenance-Visit-Checklist-popup-7ddf5d74e26544cab24ebbac799223ef?pvs=4

📝 Description

Added a maintenance visit checklist popup when clicking on Maintenance Visit Checklist on /volunteer page.

Briefly list the changes made to the code:

  1. Added a Maintenance Visit Checklist Popup component
  2. Updated VolunteerDashboard and VolunteerPage to use this new component

✔️ Verification

image
image

🏕️ (Optional) Future Work / Notes

Clicking next currently prints the currently selected site to the console. This should be updated so the website displays the maintenance checklist for the selected site.

@ItsEricSun ItsEricSun self-assigned this Sep 19, 2024
Copy link

@hams7504 hams7504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Eric! All the logic makes sense and it works great! One nitpick that I have is that the font for the text and the dropdown should be styled a little more like this:
image
Here is a link to the figma: figma

@ItsEricSun
Copy link
Author

With updated fonts and style

image
image

@neetidesai
Copy link

LGTM except for the warnings git flagged!

@neetidesai neetidesai self-requested a review September 25, 2024 13:51
Copy link

@hams7504 hams7504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants