Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for nested virtualization #159

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add support for nested virtualization #159

wants to merge 1 commit into from
+76 −0

Conversation

abiosoft
Copy link

@abiosoft abiosoft commented Aug 5, 2024 •
edited
Loading

Which issue(s) this PR fixes:

This PR adds support for nested virtualization, added in macOS 15 for m3 devices.

Additional documentation

Sample usage

platformConfig, err := vz.NewGenericPlatformConfiguration(vz.WithGenericMachineIdentifier(machineIdentifier))
if err != nil {
	return err
}

// nested virt
platformConfig.SetNestedVirtualizationEnabled(true)

@abiosoft abiosoft mentioned this pull request Aug 5, 2024
Draft
@AkihiroSuda
Copy link
Contributor

@Code-Hex Could you take a look? 🙏

@AkihiroSuda
Copy link
Contributor

ping @Code-Hex 🙇‍♂️

@hallyn
Copy link

hallyn commented Sep 6, 2024

This would be terrific :)

@abiosoft
Copy link
Author

abiosoft commented Sep 7, 2024

Instructions for those willing to test this with Lima can be found here lima-vm/lima#2530 (comment).

cfergeau
cfergeau reviewed Sep 17, 2024
View reviewed changes
virtualization_15.m Outdated Show resolved Hide resolved
cfergeau
cfergeau reviewed Sep 19, 2024
View reviewed changes
virtualization_15.m Outdated Show resolved Hide resolved
@abiosoft abiosoft force-pushed the enable-nested-virtualization branch 3 times, most recently from 1135133 to 77c5a98 Compare September 21, 2024 06:22
@abiosoft
add support for nested virtualization
8d63c17 
Signed-off-by: Abiola Ibrahim <git@abiosoft.com>
@abiosoft
Copy link
Author

I think all comments have been addressed.

Ping @Code-Hex 🥺

@cfergeau
Copy link
Contributor

I checked the latest version of the code, looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfergeau cfergeau cfergeau left review comments

@asauber asauber asauber left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abiosoft @AkihiroSuda @hallyn @cfergeau @asauber