-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update src/README with instructions on using sqlite #161
Update src/README with instructions on using sqlite #161
Conversation
@dancyy is attempting to deploy a commit to the CodeForHawaii Team on Vercel. A member of the Team first needs to authorize it. |
@@ -134,6 +134,21 @@ Follow these directions for easier database editing. | |||
- `npx prisma db push` | |||
- Run the application and confirm it works | |||
|
|||
# Prisma SQLite |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a note on why someone would want to use SQLite?
When submitting PRs, it is helpful to link the issue you are working on (in this case, #160). Fun fact: You can also have your issue be automatically closed when your PR gets merged, read more here: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue Thanks for your contribution :) |
src/README.md
Outdated
|
||
> **_NOTE:_** SQLite is a [cross-platform](https://en.wikipedia.org/wiki/Cross-platform_software) database management system that provides a highly reliable, fast, and lightweight SQL database engine for everyone to use for any purpose. | ||
> | ||
>Learn more of why someone would want to use this free & open source library here: [When to use SQLite?](https://www.sqlite.org/whentouse.html) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The benefit to using SQLite is that it may be an easier alternative to stand up to SQL Server if someone is trying to run the project locally. A caveat is the demographic questions won't load because those are hard coded in the SQL migrations. Add something like the following below the title:
Motivation
SQLite is a light-weight alternative to Microsoft SQL Server which may be easier to stand up if you're running the project locally.
Note: The demographic questions will not populate because they are hard-coded in the SQL migrations.
src/README.md
Outdated
|
||
## Why use SQLite? | ||
|
||
SQLite is a light-weight alternative to Microsoft SQL Server which may provide an easier setup solution for those running the project locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you set up SQLite? I see you added configuration instructions to connect to SQLite, but not on how to actually install SQLite.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* Provide link to set up SQLite on windows * Provide instructions for Linux and Mac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
No description provided.