Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update src/README with instructions on using sqlite #161

Merged
merged 8 commits into from
Dec 22, 2023

Conversation

dancyy
Copy link
Contributor

@dancyy dancyy commented Oct 10, 2023

No description provided.

@dancyy dancyy requested a review from avenmia October 10, 2023 10:45
@dancyy dancyy requested a review from a team as a code owner October 10, 2023 10:45
@vercel
Copy link

vercel bot commented Oct 10, 2023

@dancyy is attempting to deploy a commit to the CodeForHawaii Team on Vercel.

A member of the Team first needs to authorize it.

@@ -134,6 +134,21 @@ Follow these directions for easier database editing.
- `npx prisma db push`
- Run the application and confirm it works

# Prisma SQLite
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a note on why someone would want to use SQLite?

@tyliec
Copy link
Member

tyliec commented Oct 13, 2023

When submitting PRs, it is helpful to link the issue you are working on (in this case, #160).

Fun fact: You can also have your issue be automatically closed when your PR gets merged, read more here: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Thanks for your contribution :)

@dancyy dancyy linked an issue Oct 13, 2023 that may be closed by this pull request
src/README.md Outdated
Comment on lines 152 to 155

> **_NOTE:_** SQLite is a [cross-platform](https://en.wikipedia.org/wiki/Cross-platform_software) database management system that provides a highly reliable, fast, and lightweight SQL database engine for everyone to use for any purpose.
>
>Learn more of why someone would want to use this free & open source library here: [When to use SQLite?](https://www.sqlite.org/whentouse.html)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The benefit to using SQLite is that it may be an easier alternative to stand up to SQL Server if someone is trying to run the project locally. A caveat is the demographic questions won't load because those are hard coded in the SQL migrations. Add something like the following below the title:

Motivation

SQLite is a light-weight alternative to Microsoft SQL Server which may be easier to stand up if you're running the project locally.

Note: The demographic questions will not populate because they are hard-coded in the SQL migrations.

src/README.md Outdated

## Why use SQLite?

SQLite is a light-weight alternative to Microsoft SQL Server which may provide an easier setup solution for those running the project locally.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do you set up SQLite? I see you added configuration instructions to connect to SQLite, but not on how to actually install SQLite.

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hierr ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 2:34am

Copy link
Collaborator

@avenmia avenmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@avenmia avenmia merged commit c38223c into CodeWithAloha:main Dec 22, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update src/README with instructions on using sqlite
4 participants