Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run lint checks in CI #167

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Run lint checks in CI #167

merged 3 commits into from
Nov 16, 2023

Conversation

MichaelTamaki
Copy link
Contributor

Run lint checks in CI

Although the repo has the husky pre-commit hook, on some local machines, it does not fire (like mine). We can enforce lint check in CI to make sure that everyone is running the lint commands and that the main branch is compliant.

@MichaelTamaki MichaelTamaki requested a review from a team as a code owner October 17, 2023 05:53
@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hierr ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 4:57am

avenmia
avenmia previously approved these changes Oct 18, 2023
Copy link
Collaborator

@avenmia avenmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks!

Copy link
Collaborator

@avenmia avenmia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! :shipit:

@MichaelTamaki MichaelTamaki merged commit be98752 into main Nov 16, 2023
4 checks passed
@MichaelTamaki MichaelTamaki deleted the prettier-ci branch November 16, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants