Added unit tests for 1 component (textAnswers) using Vitest and React Testing Library #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kobebuckley
changed the title
avenmia
requested changes
Jun 18, 2024
package.json
Outdated
| "lint-staged": "^13.1.2", | ||
| "postcss": "^8.4.31", | ||
| "prettier": "^2.8.4", | ||
| "prettier-plugin-tailwindcss": "^0.2.3", | ||
| "prisma": "^4.10.0", | ||
| "prisma": "4.10.0", |
There was a problem hiding this comment.
The ^ got removed, can you add that back in?
package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "@next-auth/prisma-adapter": "^1.0.5", | ||
| "@prisma/client": "^4.10.0", | ||
| "@prisma/client": "4.10.0", |
There was a problem hiding this comment.
The ^ is removed here, can you add it back in?
| @@ -48,7 +48,7 @@ const InfoPopup = ({ title, PopupInfo }: InfoPopupProps) => { | |||
| > | |||
| <button | |||
| onClick={toggleMoreInformation} | |||
| className="absolute top-4 right-4 text-2xl lg:text-4xl" | |||
| className="absolute right-4 top-4 text-2xl lg:text-4xl" | |||
There was a problem hiding this comment.
Can you go through and switch these back to their original style order? If it's a prettier issue we can do another prettier PR. The unit tests should all still pass
There was a problem hiding this comment.
I added /* prettier-ignore */
above that line so now it won't be affected by prettier.
kobebuckley
force-pushed
the
198-add-unit-tests
branch
from
417cd72
to
c148345
Compare
…ng deployment issues
… follows up on the expectation that the element should be in the render
… causing the change
kobebuckley
force-pushed
the
198-add-unit-tests
branch
from
2b6b8ee
to
ccc53fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial setup for Vitest & React Testing Library