Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MeetUp link padding #83

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Fix MeetUp link padding #83

merged 1 commit into from
Jul 2, 2024

Conversation

MichaelTamaki
Copy link
Contributor

Summary

Fix MeetUp link padding

The "MeetUp" link used padding to simulate a space character on both sides in the sentence. It's more correct (both for accessibility and visual consistency) to use an actual space character and not use any padding.

Changes

  • Updated Section:
  • Added new feature:
  • Fixed a bug:
  • Updated documentation

Related Issue

Screenshots

Before

Screenshot 2024-07-01 at 7 14 30 PM

After

Screenshot 2024-07-01 at 7 15 04 PM

@@ -85,10 +85,10 @@ const Team = () => {
Be part of our story
</h4>
<p className="text-sm xl:text-xl py-4 lg:px-12 text-center xl:w-1/2">
You can join any
You can join any{" "}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't blame me, blame prettier for this weird syntax

Copy link
Contributor

@kobebuckley kobebuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@kobebuckley kobebuckley merged commit cb477e2 into main Jul 2, 2024
1 check passed
@kobebuckley kobebuckley deleted the fix-link-padding branch July 2, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants