From 894683d5f22df40e47772603ed02999de6a49096 Mon Sep 17 00:00:00 2001 From: Rafael Calleja Date: Tue, 11 Jan 2022 09:33:15 +0100 Subject: [PATCH 1/3] fix pull events --- .../internal/course.go | 2 +- .../internal/course_test.go | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 07-03-event-bus-implementation/internal/course_test.go diff --git a/07-03-event-bus-implementation/internal/course.go b/07-03-event-bus-implementation/internal/course.go index 1a9799f..e19a630 100644 --- a/07-03-event-bus-implementation/internal/course.go +++ b/07-03-event-bus-implementation/internal/course.go @@ -141,7 +141,7 @@ func (c *Course) Record(evt event.Event) { } // PullEvents returns all the recorded domain events. -func (c Course) PullEvents() []event.Event { +func (c *Course) PullEvents() []event.Event { evt := c.events c.events = []event.Event{} diff --git a/07-03-event-bus-implementation/internal/course_test.go b/07-03-event-bus-implementation/internal/course_test.go new file mode 100644 index 0000000..90bf2d0 --- /dev/null +++ b/07-03-event-bus-implementation/internal/course_test.go @@ -0,0 +1,16 @@ +package mooc + +import ( + "github.com/stretchr/testify/assert" + "github.com/stretchr/testify/require" + "testing" +) + +func TestCourse_PullEvents(t *testing.T) { + courseID, courseName, courseDuration := "37a0f027-15e6-47cc-a5d2-64183281087e", "Test Course", "10 months" + course, err := NewCourse(courseID, courseName, courseDuration) + require.NoError(t, err) + + assert.Len(t, course.PullEvents(), 1) + assert.Len(t, course.PullEvents(), 0) +} From 8ebdf456496d37552f3daef66cec4a2c8437d1f8 Mon Sep 17 00:00:00 2001 From: Rafael Calleja Date: Tue, 11 Jan 2022 09:34:16 +0100 Subject: [PATCH 2/3] fix pull events --- 07-01-publishing-domain-events/internal/course.go | 2 +- 07-02-domain-events-subscriber/internal/course.go | 2 +- 08-01-reading-env-variables/internal/course.go | 2 +- 08-02-build-and-deploy/internal/course.go | 2 +- 08-03-debugging/internal/course.go | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/07-01-publishing-domain-events/internal/course.go b/07-01-publishing-domain-events/internal/course.go index 9d87611..902b9b4 100644 --- a/07-01-publishing-domain-events/internal/course.go +++ b/07-01-publishing-domain-events/internal/course.go @@ -141,7 +141,7 @@ func (c *Course) Record(evt event.Event) { } // PullEvents returns all the recorded domain events. -func (c Course) PullEvents() []event.Event { +func (c *Course) PullEvents() []event.Event { evt := c.events c.events = []event.Event{} diff --git a/07-02-domain-events-subscriber/internal/course.go b/07-02-domain-events-subscriber/internal/course.go index b1cc3cd..7d04195 100644 --- a/07-02-domain-events-subscriber/internal/course.go +++ b/07-02-domain-events-subscriber/internal/course.go @@ -141,7 +141,7 @@ func (c *Course) Record(evt event.Event) { } // PullEvents returns all the recorded domain events. -func (c Course) PullEvents() []event.Event { +func (c *Course) PullEvents() []event.Event { evt := c.events c.events = []event.Event{} diff --git a/08-01-reading-env-variables/internal/course.go b/08-01-reading-env-variables/internal/course.go index c8d76ef..e1347e8 100644 --- a/08-01-reading-env-variables/internal/course.go +++ b/08-01-reading-env-variables/internal/course.go @@ -141,7 +141,7 @@ func (c *Course) Record(evt event.Event) { } // PullEvents returns all the recorded domain events. -func (c Course) PullEvents() []event.Event { +func (c *Course) PullEvents() []event.Event { evt := c.events c.events = []event.Event{} diff --git a/08-02-build-and-deploy/internal/course.go b/08-02-build-and-deploy/internal/course.go index d0840a5..08c5ad2 100644 --- a/08-02-build-and-deploy/internal/course.go +++ b/08-02-build-and-deploy/internal/course.go @@ -141,7 +141,7 @@ func (c *Course) Record(evt event.Event) { } // PullEvents returns all the recorded domain events. -func (c Course) PullEvents() []event.Event { +func (c *Course) PullEvents() []event.Event { evt := c.events c.events = []event.Event{} diff --git a/08-03-debugging/internal/course.go b/08-03-debugging/internal/course.go index 0292165..94c0245 100644 --- a/08-03-debugging/internal/course.go +++ b/08-03-debugging/internal/course.go @@ -141,7 +141,7 @@ func (c *Course) Record(evt event.Event) { } // PullEvents returns all the recorded domain events. -func (c Course) PullEvents() []event.Event { +func (c *Course) PullEvents() []event.Event { evt := c.events c.events = []event.Event{} From 8e7699dc81f2b4391e754800e45a0411a6838cb7 Mon Sep 17 00:00:00 2001 From: Rafael Calleja Date: Tue, 11 Jan 2022 09:36:31 +0100 Subject: [PATCH 3/3] mod assert --- 07-03-event-bus-implementation/internal/course_test.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/07-03-event-bus-implementation/internal/course_test.go b/07-03-event-bus-implementation/internal/course_test.go index 90bf2d0..729065d 100644 --- a/07-03-event-bus-implementation/internal/course_test.go +++ b/07-03-event-bus-implementation/internal/course_test.go @@ -11,6 +11,6 @@ func TestCourse_PullEvents(t *testing.T) { course, err := NewCourse(courseID, courseName, courseDuration) require.NoError(t, err) - assert.Len(t, course.PullEvents(), 1) + assert.GreaterOrEqual(t, len(course.PullEvents()), 1) assert.Len(t, course.PullEvents(), 0) }