Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document required permissions #47

Closed
adrianjost opened this issue Nov 16, 2022 · 5 comments · Fixed by #80
Closed

Document required permissions #47

adrianjost opened this issue Nov 16, 2022 · 5 comments · Fixed by #80

Comments

@adrianjost
Copy link

It took me a bit of time to figure out which permissions this actions needs.

In my case, adding the following worked. Maybe that should be added to the README.

jobs:
  labeler:
    ...
    permissions:
      issues: write
      pull-requests: write
    steps:
      ...
@EngJay
Copy link

EngJay commented Nov 16, 2022

+1 - after removing the github url per #40, the action runs without indication that the lack of permissions is preventing it from labeling PRs, which led me here.

@JavierCane
Copy link
Member

Good one. Thanks for opening the issue and providing the actual fix for it.

you can expect we work on this in the upcoming days/weeks at most. If you want, we would really appreciate opening a PR modifying the current README.md in order to reflect this by default and we would merge it even sooner.

Thanks!

@adrianjost
Copy link
Author

adrianjost commented Nov 17, 2022

I didn't open a PR yet, because I've used the permission stuff myself for the first time here. So I don't feel comfortable writing any documentation regarding that. I don't even know if any other potential permission defaults might affect my solution, so it only works in my environment and in others more permissions would be needed. I have no idea.

My main intent for this Issue was, to provide some information in case someone struggles with the same setup issue and hoping that someone who actually understands what I did would write some documentation eventually.

@EngJay
Copy link

EngJay commented Nov 17, 2022

@JavierCane I'll do it after work if want to assign it to me.

@AlmogBaku
Copy link

adding the permission to the issues actually solved my issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants