This repository has been archived by the owner on Dec 14, 2023. It is now read-only.
Refactor login/logout to share session clearing code #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that when logging in with another user on top of an existing session that the old session was still present on the "account select" screen. This change makes sure the session is cleared before going through the login flow, the same way as it is cleared in the logout flow. Also I've added an option to the gulpfile to allow large HTTP headers to be parsed, as I was seeing HPE_HEADER_OVERFLOW errors in the HAPI debug logs. I don't think this will happen in prod as not as many cookies are sent, as more than one domain is used for profile, zen, cd frontend etc.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when logging in with another user on top of an existing session that the old session was still present on the "account select" screen. This change makes sure the session is cleared before going through the login flow, the same way as it is cleared in the logout flow.
Also I've added an option to the gulpfile to allow large HTTP headers to be parsed, as I was seeing HPE_HEADER_OVERFLOW errors in the HAPI debug logs. I don't think this will happen in prod as not as many cookies are sent, as more than one domain is used for profile, zen, cd frontend etc.