Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about refactor this project using Modules? #59

Open
xiaguan opened this issue Mar 7, 2023 · 3 comments
Open

How about refactor this project using Modules? #59

xiaguan opened this issue Mar 7, 2023 · 3 comments

Comments

@xiaguan
Copy link

xiaguan commented Mar 7, 2023

I think your project do well. And it has the newest feature both in C++ and the OS. But one important feature modules in C++20 is missed. I think it's a nice feature. If you would , I could help you to do it .

@Codesire-Deng
Copy link
Owner

I think your project do well. And it has the newest feature both in C++ and the OS. But one important feature modules in C++20 is missed. I think it's a nice feature. If you would , I could help you to do it .

Thank you for your generous praise! C++20 module is still very fresh today. I am looking forward to the support from build tools, especially for cmake 3.26. I have no idea whether an older cmake could support C++ module across gcc and clang.

What's your opinion on building tools with C++20 module?

@xiaguan
Copy link
Author

xiaguan commented Mar 7, 2023

I use MSVC on Windows(It supports Module very well). As for linux , I tried xmake with clang. I have used it to build enough small projects, and it has done a good job. But as for projects like yours, I haven't tried. If I am free this weekend, I can provide a module version of your project.

@Codesire-Deng
Copy link
Owner

Thanks for you help! I'd love to, but I'm afraid it will be a little bit difficult to provide the module version directly without cmake, because this project detects the kernel version with cmake.

For sure other tools like xmake can do the same job, but there will be a dirty work to do. Maybe we should start from an easier demo.

What's more, we should also pay attention to the availability of intellisence like clangd with C++20 module. They work, we work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants