From 02c0c89b13628c558adfeae882e593218512a8ba Mon Sep 17 00:00:00 2001 From: mrT23 Date: Mon, 11 Dec 2023 08:29:09 +0200 Subject: [PATCH] feat: Add exception handling for discussion creation in gitlab_provider.py --- pr_agent/git_providers/gitlab_provider.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pr_agent/git_providers/gitlab_provider.py b/pr_agent/git_providers/gitlab_provider.py index 7b11ef54e..c5e77d07c 100644 --- a/pr_agent/git_providers/gitlab_provider.py +++ b/pr_agent/git_providers/gitlab_provider.py @@ -211,7 +211,11 @@ def send_inline_comment(self,body: str,edit_type: str,found: bool,relevant_file: pos_obj['new_line'] = target_line_no - 1 pos_obj['old_line'] = source_line_no - 1 get_logger().debug(f"Creating comment in {self.id_mr} with body {body} and position {pos_obj}") - self.mr.discussions.create({'body': body, 'position': pos_obj}) + try: + self.mr.discussions.create({'body': body, 'position': pos_obj}) + except Exception as e: + get_logger().debug( + f"Failed to create comment in {self.id_mr} with position {pos_obj} (probably not a '+' line)") def get_relevant_diff(self, relevant_file: str, relevant_line_in_file: int) -> Optional[dict]: changes = self.mr.changes() # Retrieve the changes for the merge request once