From 3778cc2745e50990f306fb6ef5721686b47db7b4 Mon Sep 17 00:00:00 2001 From: Paolo Mainardi Date: Thu, 22 Aug 2024 21:59:01 +0200 Subject: [PATCH] feat: skip draft by default --- pr_agent/servers/gitlab_webhook.py | 5 ++--- pr_agent/settings/configuration.toml | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/pr_agent/servers/gitlab_webhook.py b/pr_agent/servers/gitlab_webhook.py index df8f9baf1..143e45e4e 100644 --- a/pr_agent/servers/gitlab_webhook.py +++ b/pr_agent/servers/gitlab_webhook.py @@ -124,13 +124,12 @@ async def inner(data: dict): return JSONResponse(status_code=status.HTTP_200_OK, content=jsonable_encoder({"message": "success"})) log_context["sender"] = sender - should_skip_draft = get_settings().get("GITLAB.SKIP_DRAFT_MR", False) if data.get('object_kind') == 'merge_request' and data['object_attributes'].get('action') in ['open', 'reopen']: url = data['object_attributes'].get('url') draft = data['object_attributes'].get('draft') get_logger().info(f"New merge request: {url}") - if draft and should_skip_draft: + if draft: get_logger().info(f"Skipping draft MR: {url}") return JSONResponse(status_code=status.HTTP_200_OK, content=jsonable_encoder({"message": "success"})) @@ -140,7 +139,7 @@ async def inner(data: dict): mr = data['merge_request'] url = mr.get('url') draft = mr.get('draft') - if draft and should_skip_draft: + if draft: get_logger().info(f"Skipping draft MR: {url}") return JSONResponse(status_code=status.HTTP_200_OK, content=jsonable_encoder({"message": "success"})) diff --git a/pr_agent/settings/configuration.toml b/pr_agent/settings/configuration.toml index 89d8dd11e..b128aca08 100644 --- a/pr_agent/settings/configuration.toml +++ b/pr_agent/settings/configuration.toml @@ -230,7 +230,6 @@ push_commands = [ "/describe", "/review --pr_reviewer.num_code_suggestions=0", ] -skip_draft_mr = false [bitbucket_app] pr_commands = [