Update label comparison logic in pr_reviewer.py and pr_description.py…

… to consider unordered lists
Codium-ai · Mar 12, 2024 · 78cabf2 · 78cabf2
1 parent 8b29c3a
commit 78cabf2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pr_agent/tools/pr_description.py b/pr_agent/tools/pr_description.py
@@ -123,7 +123,7 @@ async def run(self):
                     user_labels = get_user_labels(original_labels)
                     new_labels = pr_labels + user_labels
                     get_logger().debug(f"published labels", artifact=new_labels)
-                    if new_labels != original_labels:
+                    if sorted(new_labels) != sorted(original_labels):
                         self.git_provider.publish_labels(new_labels)
                     else:
                         get_logger().debug(f"Labels are the same, not updating")

diff --git a/pr_agent/tools/pr_reviewer.py b/pr_agent/tools/pr_reviewer.py
@@ -378,7 +378,7 @@ def set_review_labels(self, data):
                 else:
                     current_labels_filtered = []
                 new_labels = review_labels + current_labels_filtered
-                if (current_labels or review_labels) and new_labels != current_labels:
+                if (current_labels or review_labels) and sorted(new_labels) != sorted(current_labels):
                     get_logger().info(f"Setting review labels:\n{review_labels + current_labels_filtered}")
                     self.git_provider.publish_labels(new_labels)
                 else: