Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added title and description to /describe command prompt #180

Conversation

zmeir
Copy link
Contributor

@zmeir zmeir commented Aug 7, 2023

It can sometimes be beneficial for the agent to read the original PR description (as written by the user) to have a better understanding of the context. The code diff alone is great to understand what is happening in the PR, but from the description the agent can understand the why. We often use the description to describe the bug that prompted the fix, the requirement that lead to this feature, or even some form of design for the PR. All of these can give the agent better context to write a better description on its own.

It can sometimes be beneficial for the agent to read the original PR description (as written by the user) to have a better understanding of the context.  
The code diff alone is great to understand __what__ is happening in the PR, but from the description the agent can understand the __why__. We often use the description to describe the bug that prompted the fix, the requirement that lead to this feature, or even some form of design for the PR. All of these can give the agent better context to write a better description on its own.
@okotek okotek requested a review from mrT23 August 7, 2023 10:27
@mrT23
Copy link
Collaborator

mrT23 commented Aug 7, 2023

I tried that at the beginning.

When you do this naive implementation, the model tends to copy the initial PR title and description
(similar but far worse than the 'commit' issue you raised).

@zmeir
Copy link
Contributor Author

zmeir commented Aug 7, 2023

Hmm interesting. Maybe instead of calling these fields title/description we can use something like "original user description - only use as a non-obligarory reference if it fits the observed PR code".

@mrT23
Copy link
Collaborator

mrT23 commented Aug 7, 2023

i will play a bit with the prompting tomorrow, and see how it goes

@mrT23 mrT23 removed the wont solve label Aug 7, 2023
@mrT23
Copy link
Collaborator

mrT23 commented Aug 9, 2023

see #188

@mrT23 mrT23 added the solved label Aug 9, 2023
@mrT23 mrT23 closed this Aug 9, 2023
@zmeir zmeir deleted the zmeir-add_title_and_description_to_describe_command branch August 9, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants