Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix get_user_description in case pr_description.enable_pr_type=false #449

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

zmeir
Copy link
Contributor

@zmeir zmeir commented Nov 13, 2023

Fixes an issue when getting the user description after a PR-Agent description was already generated, in case the configuration setting pr_description.enable_pr_type was false.

Fixes an issue when getting the user description after a PR-Agent description was already generated, in case the configuration setting `pr_description.enable_pr_type` was `false`.
@coditamar
Copy link
Contributor

/generate_labels

@barnett-yuxiang
Copy link
Contributor

/generate_labels

Copy link
Contributor

@barnett-yuxiang barnett-yuxiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No Unit Test code submitted?

@mrT23 mrT23 merged commit e878bbb into Codium-ai:main Nov 15, 2023
2 checks passed
@mrT23
Copy link
Collaborator

mrT23 commented Nov 15, 2023

PR Analysis

(review updated until commit 7d89b82)

  • 🎯 Main theme: This PR is about fixing an issue in the get_user_description function when the configuration setting pr_description.enable_pr_type is set to false.
  • 📝 PR summary: The PR fixes a bug in the get_user_description function of the git_provider.py file. The bug was causing incorrect behavior when the configuration setting pr_description.enable_pr_type was set to false. The fix involves changing the condition that checks the start of the description.
  • 📌 Type of PR: Bug fix
  • 🧪 Relevant tests added: No
  • ⏱️ Estimated effort to review [1-5]: 1, because the PR is small and the change is straightforward.
  • 🔒 Security concerns: No security concerns found

PR Feedback

  • 💡 General suggestions: The PR is concise and addresses a specific issue which is good. However, it would be beneficial to add tests that cover this specific case to prevent future regressions.

  • 🤖 Code feedback:

@mrT23
Copy link
Collaborator

mrT23 commented Nov 15, 2023

Persistent review updated to latest commit 7d89b82

@zmeir zmeir deleted the patch-1 branch November 16, 2023 07:26
@mrT23
Copy link
Collaborator

mrT23 commented Nov 17, 2023

Preparing review...

2 similar comments
@mrT23
Copy link
Collaborator

mrT23 commented Nov 17, 2023

Preparing review...

@mrT23
Copy link
Collaborator

mrT23 commented Nov 17, 2023

Preparing review...

yochail pushed a commit to yochail/pr-agent that referenced this pull request Feb 11, 2024
Fix `get_user_description` in case `pr_description.enable_pr_type=false`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants