-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added BitBucket Server and Data Center support #455
Conversation
Signed-off-by: Luca Simone <info@lucasimone.info>
/review |
PR Analysis(review updated until commit 26dc2e9)
PR Feedback
How to use
|
/improve --extended |
pass | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: The 'remove_comment' function is currently a pass-through function. If it's not implemented yet, consider raising a NotImplementedError to indicate this.
pass | |
def remove_comment(self, comment): | |
raise NotImplementedError("Remove comment function not implemented yet.") |
pass | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: The 'publish_labels' function is currently a pass-through function. If it's not implemented yet, consider raising a NotImplementedError to indicate this.
pass | |
def publish_labels(self, pr_types: list): | |
raise NotImplementedError("Publish labels function not implemented yet.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we should change that method and raise an exception when labels are not supported by bitbucket. To me, this sounds better as a pass.
Another way could be to create and raise a NotSupportedException.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Hi @lukefx
|
@mrT23 labels as comment is ugly as hell :) and you cannot search for them... This is not useful in any way. I don't know if you've seen that but Bitbucket's server UI is pretty behind and old with the current cloud version. |
not a separate comment. for example, if you use custom labels, in 'describe', you will have an additional section in the PR header: 'PR custom Lables'. |
ok I will check and modify the code :) |
i don't think you need to modify for that anything. you do have the 'is_supported' method. my main request is to add some documentation, otherwise it will be very hard to other people to use this mode |
@CodiumAI-Agent /review |
Persistent review updated to latest commit 26dc2e9 |
/improve --extended |
Preparing review... |
Preparing review... |
1 similar comment
Preparing review... |
@lukefx can you add a few lines fo documentation, so we can merge this ? |
Yes, I'm on it... I also added the support for webhooks and I will commit it soon. Sorry for the wait |
@mrT23 Please review the doc if is enough... |
@lukefx |
Added BitBucket Server and Data Center support
Hi all, this is an initial implementation that works on BitBucket Server and Data Center.
Just enable it on configuration.toml and
And:
python cli.py --pr_url https://git.onpreminstanceofbitbucket.com/projects/PROJECT/repos/REPO/pull-requests/1 review