Tr/patch extra lines before and after

[mrT23]

PR Type

Enhancement, Tests

---

Description

• Refactored patch extension functionality to allow separate control over lines added before and after changes
• Updated extend_patch function and related methods to use new patch_extra_lines_before and patch_extra_lines_after parameters
• Modified configuration to set patch_extra_lines_before=4 and patch_extra_lines_after=2
• Increased max_context_tokens from 10000 to 16000 for code suggestions
• Added new model 'claude-3-5-sonnet' with 100000 token limit
• Updated unit tests to reflect new patch extension functionality
• Added new tests for patch extension with extra lines
• Updated documentation to explain new patch extension configuration

---

Changes walkthrough 📝

	Relevant files
Configuration changes	__init__.py Add new Claude model                                                                          pr_agent/algo/init.py Added 'claude-3-5-sonnet' model with a token limit of 100000 +1/-0      configuration.toml Update configuration for patch extension and context          pr_agent/settings/configuration.toml Changed patch_extra_lines to separate patch_extra_lines_before and patch_extra_lines_after Increased max_context_tokens from 10000 to 16000 +3/-2
Enhancement	git_patch_processing.py Refactor patch extension for flexibility                                  pr_agent/algo/git_patch_processing.py Modified extend_patch function to accept separate parameters for lines before and after Updated patch extension logic to use new parameters +8/-19    pr_processing.py Update PR processing for new patch extension                          pr_agent/algo/pr_processing.py Updated get_pr_diff and pr_generate_extended_diff to use separate before and after line parameters Modified patch extension calls to use new configuration settings +15/-17  pr_code_suggestions.py Enable extra lines in code suggestions                                      pr_agent/tools/pr_code_suggestions.py Changed disable_extra_lines parameter to False in _prepare_prediction method +1/-1
Tests	test_extend_patch.py Update and add tests for patch extension                                  tests/unittest/test_extend_patch.py Updated existing tests to use new patch_extra_lines_before and patch_extra_lines_after parameters Added new test class PRProcessingTest with tests for patch extension with extra lines +65/-45
Documentation	additional_configurations.md Update documentation for new patch extension config            docs/docs/usage-guide/additional_configurations.md Updated configuration example to show separate patch_extra_lines_before and patch_extra_lines_after parameters +2/-1

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[codiumai-pr-agent-pro]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🏅 Score: 85

🧪 PR contains tests

🔒 No security concerns identified

🔀 Multiple PR themes Sub-PR theme: Refactor patch extension to support separate before and after line counts Relevant files: pr_agent/algo/git_patch_processing.py pr_agent/algo/pr_processing.py tests/unittest/test_extend_patch.py Sub-PR theme: Update configuration and add new Claude model Relevant files: pr_agent/algo/init.py pr_agent/tools/pr_code_suggestions.py pr_agent/settings/configuration.toml

⚡ Key issues to review Code Refactoring The extend_patch function has been significantly refactored to handle separate patch_extra_lines_before and patch_extra_lines_after parameters. This change affects the core functionality and should be carefully reviewed for correctness and edge cases. Configuration Update The PR introduces new configuration parameters patch_extra_lines_before and patch_extra_lines_after. Ensure these are correctly used throughout the codebase and that they don't introduce any unexpected behavior.

[codiumai-pr-agent-pro]

PR Code Suggestions ✨

Category	Suggestion	Score
Best practice	Use parameterized tests to reduce code duplication and improve test maintainability Consider using parameterized tests to reduce code duplication and make it easier to add new test cases for the extend_patch function. tests/unittest/test_extend_patch.py [10-32] -def test_happy_path(self): - original_file_str = 'line1\nline2\nline3\nline4\nline5' - patch_str = '@@ -2,2 +2,2 @@ init()\n-line2\n+new_line2\nline3' - num_lines = 1 - expected_output = '@@ -1,4 +1,4 @@ init()\nline1\n-line2\n+new_line2\nline3\nline4' +@pytest.mark.parametrize("original_file_str, patch_str, num_lines, expected_output", [ + ('line1\nline2\nline3\nline4\nline5', + '@@ -2,2 +2,2 @@ init()\n-line2\n+new_line2\nline3', + 1, + '@@ -1,4 +1,4 @@ init()\nline1\n-line2\n+new_line2\nline3\nline4'), + ('line1\nline2\nline3\nline4\nline5', '', 1, ''), + ('line1\nline2\nline3\nline4\nline5', + '@@ -2,2 +2,2 @@ init()\n-line2\n+new_line2\nline3', + 0, + '@@ -2,2 +2,2 @@ init()\n-line2\n+new_line2\nline3'), +]) +def test_extend_patch(self, original_file_str, patch_str, num_lines, expected_output): actual_output = extend_patch(original_file_str, patch_str, patch_extra_lines_before=num_lines, patch_extra_lines_after=num_lines) assert actual_output == expected_output -# Tests that the function returns an empty string when patch_str is empty -def test_empty_patch(self): - original_file_str = 'line1\nline2\nline3\nline4\nline5' - patch_str = '' - num_lines = 1 - expected_output = '' - assert extend_patch(original_file_str, patch_str, - patch_extra_lines_before=num_lines, patch_extra_lines_after=num_lines) == expected_output - -# Tests that the function returns the original patch when num_lines is 0 -def test_zero_num_lines(self): - original_file_str = 'line1\nline2\nline3\nline4\nline5' - patch_str = '@@ -2,2 +2,2 @@ init()\n-line2\n+new_line2\nline3' - num_lines = 0 - assert extend_patch(original_file_str, patch_str, - patch_extra_lines_before=num_lines, patch_extra_lines_after=num_lines) == patch_str - Apply this suggestion Suggestion importance[1-10]: 8 Why: Parameterized tests significantly improve test maintainability and make it easier to add new test cases.	8
Maintainability	Extract hardcoded boolean value into a configuration setting for improved flexibility Consider extracting the disable_extra_lines parameter into a configuration setting or a constant to improve flexibility and maintainability of the code. pr_agent/tools/pr_code_suggestions.py [286-289] +DISABLE_EXTRA_LINES = get_settings().config.disable_extra_lines_for_code_suggestions self.patches_diff = get_pr_diff(self.git_provider, self.token_handler, model, add_line_numbers_to_hunks=True, - disable_extra_lines=False) + disable_extra_lines=DISABLE_EXTRA_LINES) Apply this suggestion Suggestion importance[1-10]: 7 Why: This suggestion improves code flexibility and maintainability by moving a hardcoded value to a configuration setting.	7
	Use a more descriptive variable name to improve code readability Consider using a more descriptive variable name instead of res to improve code readability. For example, you could use hunk_info or patch_details. pr_agent/algo/git_patch_processing.py [37-46] -res = list(match.groups()) -for i in range(len(res)): - res[i] = res[i].strip() if res[i] else res[i] -if len(res) >= 3: - start1, size1, size2 = map(int, res[:3]) +hunk_info = list(match.groups()) +for i in range(len(hunk_info)): + hunk_info[i] = hunk_info[i].strip() if hunk_info[i] else hunk_info[i] +if len(hunk_info) >= 3: + start1, size1, size2 = map(int, hunk_info[:3]) start2 = 0 -section_header = res[4] +section_header = hunk_info[4] Apply this suggestion Suggestion importance[1-10]: 5 Why: The suggestion improves code readability, but it's a minor change that doesn't significantly impact functionality.	5
Enhancement	Use tuple unpacking for multiple assignments to improve code conciseness Consider using a tuple unpacking assignment instead of multiple separate assignments for PATCH_EXTRA_LINES_BEFORE and PATCH_EXTRA_LINES_AFTER to make the code more concise and readable. pr_agent/algo/pr_processing.py [36-40] if disable_extra_lines: - PATCH_EXTRA_LINES_BEFORE = 0 - PATCH_EXTRA_LINES_AFTER = 0 + PATCH_EXTRA_LINES_BEFORE, PATCH_EXTRA_LINES_AFTER = 0, 0 else: - PATCH_EXTRA_LINES_BEFORE = get_settings().config.patch_extra_lines_before - PATCH_EXTRA_LINES_AFTER = get_settings().config.patch_extra_lines_after + PATCH_EXTRA_LINES_BEFORE, PATCH_EXTRA_LINES_AFTER = ( + get_settings().config.patch_extra_lines_before, + get_settings().config.patch_extra_lines_after + ) Apply this suggestion Suggestion importance[1-10]: 6 Why: This suggestion enhances code readability and conciseness, which is beneficial for maintainability.	6

[codecov]

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 17.27%. Comparing base (ab69f17) to head (e238a88).
Report is 3 commits behind head on main.

Files	Patch %	Lines
pr_agent/algo/pr_processing.py	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1109      +/-   ##
==========================================
- Coverage   17.27%   17.27%   -0.01%     
==========================================
  Files          57       57              
  Lines        7790     7792       +2     
==========================================
  Hits         1346     1346              
- Misses       6444     6446       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.