Tr/patch extra lines before and after

[mrT23]

PR Type

Enhancement, Tests

---

Description

• Refactored patch extension functionality to allow separate control of lines before and after changes
• Updated extend_patch function and related methods to use new patch_extra_lines_before and patch_extra_lines_after parameters
• Modified configuration to set patch_extra_lines_before to 4 and patch_extra_lines_after to 2
• Increased max_context_tokens to 16000 for improved context handling
• Added new 'claude-3-5-sonnet' model to the supported models list
• Updated tests to reflect new patch extension functionality
• Enabled extra lines for code suggestions by default
• Updated documentation to explain new configuration options

---

Changes walkthrough 📝

	Relevant files
Configuration changes	__init__.py Add new Claude 3.5 Sonnet model                                                    pr_agent/algo/init.py Added 'claude-3-5-sonnet' model with a token limit of 100000 +1/-0      configuration.toml Update configuration for new patch extension settings        pr_agent/settings/configuration.toml Changed patch_extra_lines to separate patch_extra_lines_before and patch_extra_lines_after Increased max_context_tokens from 10000 to 16000 +3/-2
Enhancement	git_patch_processing.py Refactor patch extension for flexible line handling            pr_agent/algo/git_patch_processing.py Modified extend_patch function to accept separate parameters for lines before and after Updated patch extension logic to use new parameters +8/-19    pr_processing.py Update PR processing for new patch extension parameters    pr_agent/algo/pr_processing.py Updated get_pr_diff and pr_generate_extended_diff to use separate before and after line parameters Modified patch extension calls to use new configuration settings +15/-17  pr_code_suggestions.py Enable extra lines for code suggestions                                    pr_agent/tools/pr_code_suggestions.py Changed disable_extra_lines parameter to False in _prepare_prediction method +1/-1
Tests	test_extend_patch.py Update and add tests for new patch extension functionality tests/unittest/test_extend_patch.py Updated existing tests to use new patch_extra_lines_before and patch_extra_lines_after parameters Added new test class PRProcessingTest with tests for extended patches +65/-45
Documentation	additional_configurations.md Update documentation for new patch extension configuration docs/docs/usage-guide/additional_configurations.md Updated configuration example to show separate patch_extra_lines_before and patch_extra_lines_after parameters +2/-1

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[codiumai-pr-agent-pro]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🏅 Score: 85

🧪 No relevant tests

🔒 No security concerns identified

🔀 Multiple PR themes Sub-PR theme: Refactor patch extension functionality Relevant files: pr_agent/algo/git_patch_processing.py pr_agent/algo/pr_processing.py tests/unittest/test_extend_patch.py Sub-PR theme: Update configuration and add new Claude model Relevant files: pr_agent/algo/init.py pr_agent/settings/configuration.toml Sub-PR theme: Update code suggestions and documentation Relevant files: pr_agent/tools/pr_code_suggestions.py docs/docs/usage-guide/additional_configurations.md

⚡ Key issues to review Code Refactoring The extend_patch function has been refactored to use separate parameters for lines before and after changes. This change affects the function's interface and usage throughout the codebase. Configuration Update New configuration options patch_extra_lines_before and patch_extra_lines_after have been introduced to replace the single patch_extra_lines option. This change affects how patch extension is configured and applied throughout the PR processing.

[codiumai-pr-agent-pro]

PR Code Suggestions ✨

Category	Suggestion	Score
Best practice	Use parameterized tests to reduce code duplication in test cases Consider using parameterized tests to reduce code duplication and improve test maintainability for similar test cases. tests/unittest/test_extend_patch.py [10-24] -def test_happy_path(self): - original_file_str = 'line1\nline2\nline3\nline4\nline5' - patch_str = '@@ -2,2 +2,2 @@ init()\n-line2\n+new_line2\nline3' - num_lines = 1 - expected_output = '@@ -1,4 +1,4 @@ init()\nline1\n-line2\n+new_line2\nline3\nline4' +@pytest.mark.parametrize("original_file_str, patch_str, num_lines, expected_output", [ + ('line1\nline2\nline3\nline4\nline5', + '@@ -2,2 +2,2 @@ init()\n-line2\n+new_line2\nline3', + 1, + '@@ -1,4 +1,4 @@ init()\nline1\n-line2\n+new_line2\nline3\nline4'), + ('line1\nline2\nline3\nline4\nline5', + '', + 1, + ''), +]) +def test_extend_patch_cases(self, original_file_str, patch_str, num_lines, expected_output): actual_output = extend_patch(original_file_str, patch_str, patch_extra_lines_before=num_lines, patch_extra_lines_after=num_lines) assert actual_output == expected_output -# Tests that the function returns an empty string when patch_str is empty -def test_empty_patch(self): - original_file_str = 'line1\nline2\nline3\nline4\nline5' - patch_str = '' - num_lines = 1 - expected_output = '' - assert extend_patch(original_file_str, patch_str, - patch_extra_lines_before=num_lines, patch_extra_lines_after=num_lines) == expected_output - Apply this suggestion Suggestion importance[1-10]: 8 Why: Parameterized tests can significantly reduce code duplication and improve test maintainability, which is a valuable improvement for the test suite.	8
Enhancement	Extract patch extension logic into a separate function for better modularity Consider extracting the patch extension logic into a separate function to improve code modularity and reusability. pr_agent/algo/pr_processing.py [404-407] +def get_patch_extension_params(): + return { + 'patch_extra_lines_before': get_settings().config.patch_extra_lines_before, + 'patch_extra_lines_after': get_settings().config.patch_extra_lines_after + } + patches_extended, total_tokens, patches_extended_tokens = pr_generate_extended_diff( pr_languages, token_handler, add_line_numbers_to_hunks=True, - patch_extra_lines_before=get_settings().config.patch_extra_lines_before, - patch_extra_lines_after=get_settings().config.patch_extra_lines_after) + **get_patch_extension_params()) Apply this suggestion Suggestion importance[1-10]: 7 Why: This suggestion enhances code modularity and reusability, which can improve maintainability in the long run.	7
Maintainability	Use a more descriptive variable name to improve code readability Consider using a more descriptive variable name instead of res to improve code readability. For example, you could use hunk_info or patch_details. pr_agent/algo/git_patch_processing.py [37-41] -res = list(match.groups()) -for i in range(len(res)): - if res[i] is not None: - res[i] = res[i].decode('utf-8') -start1, size1, size2 = map(int, res[:3]) +hunk_info = list(match.groups()) +for i in range(len(hunk_info)): + if hunk_info[i] is not None: + hunk_info[i] = hunk_info[i].decode('utf-8') +start1, size1, size2 = map(int, hunk_info[:3]) Apply this suggestion Suggestion importance[1-10]: 6 Why: The suggestion improves code readability by using a more descriptive variable name, which is a good practice but not critical.	6
	Add comments to explain the purpose of configuration options Consider adding comments to explain the purpose and impact of the patch_extra_lines_before and patch_extra_lines_after configuration options. pr_agent/settings/configuration.toml [23-24] +# Number of extra lines to include before each patch hunk for context patch_extra_lines_before = 4 +# Number of extra lines to include after each patch hunk for context patch_extra_lines_after = 2 Apply this suggestion Suggestion importance[1-10]: 5 Why: While adding comments is beneficial for code clarity, it's a minor improvement that doesn't affect functionality.	5