Tr/err protections

[mrT23]

PR Type

Enhancement, Bug fix

---

Description

• Added error handling for empty system prompt in litellm_ai_handler.py when using Claude model
• Improved type conversion and error handling in utils.py:
  • Converted 'relevant tests' value to string to prevent potential errors
  • Enhanced error handling for custom label settings
  • Fixed potential KeyError when accessing config settings
• These changes improve the robustness of the code and prevent potential runtime errors

---

Changes walkthrough 📝

	Relevant files
Error handling	litellm_ai_handler.py Error handling for empty system prompt                                      pr_agent/algo/ai_handlers/litellm_ai_handler.py Added error handling for empty system prompt when using Claude model Inserts a newline character as system prompt to prevent OpenAI API error +4/-0
Bug fix	utils.py Improved error handling and type conversion                            pr_agent/algo/utils.py Added type conversion for 'relevant tests' value to string Improved error handling for custom label settings Fixed potential KeyError when accessing config settings +5/-3

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[codiumai-pr-agent-pro]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🏅 Score: 95

🧪 No relevant tests

🔒 No security concerns identified

🔀 Multiple PR themes Sub-PR theme: Add error handling for empty system prompt in Claude model Relevant files: pr_agent/algo/ai_handlers/litellm_ai_handler.py Sub-PR theme: Improve type conversion and error handling in utils.py Relevant files: pr_agent/algo/utils.py

⚡ Key issues to review Potential Bug The str() function is called on value before stripping and lowercasing it. This might cause issues if value is not a string or is None.

[codiumai-pr-agent-pro]

PR Code Suggestions ✨

Category	Suggestion	Score
Enhancement	Remove redundant condition to simplify code structure The condition if enable_custom_labels: is redundant because it's always true when the inner condition is checked. Consider removing the outer condition to simplify the code structure. pr_agent/algo/utils.py [685-687] -if enable_custom_labels: - if label in custom_labels: - continue +if label in custom_labels: + continue Apply this suggestion Suggestion importance[1-10]: 8 Why: The suggestion correctly identifies a redundant condition that can be safely removed, improving code clarity and efficiency.	8
	Remove unnecessary string conversion before string manipulation The str() function is unnecessary when calling strip() on value, as strip() already returns a string. Remove the str() call to simplify the code. pr_agent/algo/utils.py [150] -value = str(value).strip().lower() +value = value.strip().lower() Apply this suggestion Suggestion importance[1-10]: 5 Why: The suggestion is correct and improves code efficiency slightly, but the impact is minimal as the str() function is idempotent for string inputs.	5
Maintainability	Use a constant for the empty system prompt instead of a hardcoded value Consider using a constant or configuration value for the empty system prompt instead of a hardcoded newline character. This would make the code more maintainable and allow for easier changes in the future. pr_agent/algo/ai_handlers/litellm_ai_handler.py [109-112] +EMPTY_SYSTEM_PROMPT = "\n" if 'claude' in model and not system: - system = "\n" + system = EMPTY_SYSTEM_PROMPT get_logger().warning( - "Empty system prompt for claude model. Adding a newline character to prevent OpenAI API error.") + f"Empty system prompt for claude model. Adding '{EMPTY_SYSTEM_PROMPT}' to prevent OpenAI API error.") Apply this suggestion Suggestion importance[1-10]: 7 Why: Using a constant improves maintainability and readability, but the current implementation is functional and the change is not critical.	7