-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
checking for publish_output in the suggestions tool exception handler #1184
checking for publish_output in the suggestions tool exception handler #1184
Conversation
PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here. PR Reviewer Guide 🔍
|
PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here. PR Code Suggestions ✨
|
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
self.git_provider.publish_comment(f"Failed to generate code suggestions for PR") | ||
except Exception as e: | ||
pass | ||
if get_settings().config.publish_output: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move this to line 176
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't the progress_response (as well as the initial_comment) not exist if publish_output is false? Therefore it makes sense to wrap all of the output publishing logic here in the publish_output check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont know. ok
Preparing review... |
13 similar comments
Preparing review... |
Preparing review... |
Preparing review... |
Preparing review... |
Preparing review... |
Preparing review... |
Preparing review... |
Preparing review... |
Preparing review... |
Preparing review... |
Preparing review... |
Preparing review... |
Preparing review... |
PR Type
Bug fix
Description
publish_output
configuration in the exception handler of the code suggestions toolpublish_output
is set to TrueChanges walkthrough 📝
pr_code_suggestions.py
Improve error handling in code suggestions tool
pr_agent/tools/pr_code_suggestions.py
publish_output
in the exception handlerpublish_output
condition