Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tensorflow wrapper #1171

Merged
merged 10 commits into from
Aug 28, 2024
Merged

feat: tensorflow wrapper #1171

merged 10 commits into from
Aug 28, 2024

Conversation

yimuchen
Copy link
Contributor

@yimuchen yimuchen commented Aug 26, 2024

Adding a wrapper for running tensorflow inference models

  • [] Properly handle treatment of missing values. Tensorflow does not work with missing values. User defined code will require explicating padding with dummy values.
  • Dask awkward type tracing generates mismatched dimensions. User side definitions will need to define ensure the arrays passed will have the correct dimensions.

Discussion of tensorflow operations:

  • Add accelerator device handling (do we need to?)
  • Moving to use model.predict instead of model.__call__ [1]. The current implementation has issues with model.predict, in particular with type tracing arrays. Do we need to do this if batching is already handled by dask anyway?

[1] https://keras.io/getting_started/faq/#whats-the-difference-between-model-methods-predict-and-call

tests/test_ml_tools.py Outdated Show resolved Hide resolved
@yimuchen yimuchen changed the title feat (wip): tensorflow wrapper feat: tensorflow wrapper Aug 27, 2024
@yimuchen
Copy link
Contributor Author

Added documentation for common data mangling patterns.

@lgray lgray merged commit 2aaf4f0 into CoffeaTeam:master Aug 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants