Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spain flavour #602

Open
wants to merge 40 commits into
base: dev
Choose a base branch
from
Open

Spain flavour #602

wants to merge 40 commits into from

Conversation

ArnauGit
Copy link

@ArnauGit ArnauGit commented Sep 1, 2023

#Failing to reform should trigger a revolution (should be trying to enact Council Rep.) /and trying to avoid new tag.

Arcadyi and others added 2 commits August 30, 2023 06:32
Nationalize Public Utility Companies
Religious Nationalism
Administrative
Supremacist
#Ruling IGs need to be revised, sometimes get triggered, sometimes not
@raxo2222 raxo2222 changed the base branch from master to dev September 1, 2023 10:53
ArnauGit and others added 12 commits September 2, 2023 10:20
Changed code for government IGs
Added ideas
Carrero Blanco as securocrat leader
Franco gains Caudillo trait
Added Caudillo trait for Franco
Added a timed modifier called Francoism, which helps set up Spain with a contested government that is somewhat legitimate, by modifying the clout of the 3 interest groups in power and suppressing the other interest groups. The modifier currently lasts for 10 years.
fixed the issue with character names not appearing when using the create_character effect
Julio Muñoz Ramonet - Entrepreneur
Raimundo Llopis - Laborists
Enrique Pla - Moralists
Jose Ortega y Gasset - Intelligentsia
Raimundo Fernandez-Cuesta - Patriots
New path for CWP made icon characters
@ArnauGit ArnauGit marked this pull request as ready for review September 2, 2023 17:48
@DZappala
Copy link
Member

DZappala commented Sep 4, 2023

@ArnauGit Dev has now been updated to 1.5, please review this branch on your machine and ensure that it works with 1.5. I have merged dev into this branch and found no merge conflicts, but you should both review your files and run the mod — checking the error log to be sure.

@ArnauGit ArnauGit changed the title Update Spanish laws (now within law_package) Spain flavour Sep 10, 2023
ig_leader = yes
birth_date = 1895.10.8
interest_group = ig:ig_laborists
ideology = ideology_egalitarian
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

egalitarian is not a leader ideology!
Make sure to pull character ideologies only from the files prepended with "cwp_00_leader_"

ig_leader = yes
birth_date = 1876.12.19
interest_group = ig_moralists
ideology = ideology_catholic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

egalitarian is not a leader ideology, it belongs to just the moralists as an IG ideology.
Make sure to pull character ideologies only from the files prepended with "cwp_00_leader_"

ig_leader = yes
birth_date = 1895.2.27
interest_group = ig_laborists
ideology = ideology_proletarian
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

egalitarian is not a leader ideology, it belongs only to the laborists IG.
Make sure to pull character ideologies only from the files prepended with "cwp_00_leader_"

ig_leader = yes
birth_date = 1895.2.27
interest_group = ig_intelligentsia
ideology = ideology_academic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

egalitarian is not a leader ideology, this ideology only belongs to the intelligentsia.
Make sure to pull character ideologies only from the files prepended with "cwp_00_leader_"

ig_leader = yes
birth_date = 1916.2.18
interest_group = ig_entrepreneurs
ideology = ideology_assimilative
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

egalitarian is not a leader ideology, this ideology only belongs to the entrepreneurs IG.
Make sure to pull character ideologies only from the files prepended with "cwp_00_leader_"

}
}
option = {
name = franco_peron_event.2.a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should maybe be a negative value from Spain here to contrast the other option and vice versa with the US if Argentina goes with spain.

}
}
ai_chance = {
base = 100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unrealistic to force the AI to always side with spain, rather this should potentially be based of their already existing opinion. Unless of course this event spawns at the beginning of the game, but there's no trigger for this event so I can't confirm.

Comment on lines 1 to 6
l_english:
franco_peron_event.1.t: "Franco-Perón Protocols"
franco_peron_event.1.d: "The possibility of Argentina's Peronist government assisting the isolated Spain by sending grain and other agricultural products involves a multifaceted consideration of diplomatic, economic, and political factors. This assistance could strengthen diplomatic ties, generate revenue for Argentina's economy, and stimulate its agricultural sector. However, it would probably anger the USA as Spain's political situation is not seen with good eyes, making it a complex decision requiring careful consideration."
franco_peron_event.1.f: "Maybe Franco is the demonstration of a political third-way."
franco_peron_event.1.a: "Let's send the help."
franco_peron_event.2.a: "We should take care of ourselves."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
l_english:
franco_peron_event.1.t: "Franco-Perón Protocols"
franco_peron_event.1.d: "The possibility of Argentina's Peronist government assisting the isolated Spain by sending grain and other agricultural products involves a multifaceted consideration of diplomatic, economic, and political factors. This assistance could strengthen diplomatic ties, generate revenue for Argentina's economy, and stimulate its agricultural sector. However, it would probably anger the USA as Spain's political situation is not seen with good eyes, making it a complex decision requiring careful consideration."
franco_peron_event.1.f: "Maybe Franco is the demonstration of a political third-way."
franco_peron_event.1.a: "Let's send the help."
franco_peron_event.2.a: "We should take care of ourselves."
l_english:
franco_peron_event.1.t: "The Franco-Perón Protocol"
franco_peron_event.1.d: "Following years of wartime, Spain is in need of our help. Perhaps it's time we extend an olive branch to our homeland and their powerful leader."
franco_peron_event.1.f: "Involving a multifaceted scheme of diplomatic, economic and political considerations, Argentina's Perónist government decides whether or not to assist an isolated Spain by way of agricultural aid. This assistance could strengthen diplomatic ties, generate revenue for Argentina's economy, and stimulate its agricultural sector. However, given Franco's political perception, drifting from their sphere will anger the US. A complex decision faces Perón's government."
franco_peron_event.1.a: "Let's send them aid."
franco_peron_event.2.a: "We should take care of ourselves."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some various edits here to grammar and phrasing. As well, shortened the large text description to include the most relevant information.

Comment on lines 1 to 4
l_english:
francoist_reform: "Francoist Reform"
francoist_reform_reason: "After the defeat of fascism in the war we need to change some fundamental things to get international recognition. It is time to slowly enforce some minimal reforms, we are not fascists, aren't we...?"
francoist_reform_goal: "Our ideology was just based on Catholicism afterall. We will use Movimiento Nacional instead of the Party"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
l_english:
francoist_reform: "Francoist Reform"
francoist_reform_reason: "After the defeat of fascism in the war we need to change some fundamental things to get international recognition. It is time to slowly enforce some minimal reforms, we are not fascists, aren't we...?"
francoist_reform_goal: "Our ideology was just based on Catholicism afterall. We will use Movimiento Nacional instead of the Party"
l_english:
francoist_reform: "Francoist Reform"
francoist_reform_reason: "With the defeat of fascism reforms must be made to garner international recognition. Because we're not fascists... #italic right?#!"
francoist_reform_goal: "Our ideology was just based on Catholicism after all. It's time for a #italic Movimiento Nacional!#!"

Followed Dom's corrections.
Changed the francoist_reform_goal to "Our ideology was just based on Catholicism after all. It's time to turn back to Falangism!" as more suitable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants