Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests are still hitting the twitch api #140

Open
ColeWalker opened this issue Oct 8, 2020 · 4 comments
Open

Tests are still hitting the twitch api #140

ColeWalker opened this issue Oct 8, 2020 · 4 comments
Labels
bug Something isn't working high priority testing typescript

Comments

@ColeWalker
Copy link
Owner

Some of our tests are still hitting the twitch api, which is not ideal for rapid testing.
@CodeItQuick
Copy link

Thanks Cole, I'll see if I can tackle some of this, no promises yet

@ColeWalker ColeWalker added bug Something isn't working high priority typescript labels Oct 8, 2020
@CodeItQuick
Copy link

This was a misunderstanding/miscommunication on my part and can be closed?

@CodeItQuick CodeItQuick mentioned this issue Oct 10, 2020
Closed
@CodeItQuick
Copy link

I added a PR that addresses one of the endpoints that currently hits the Twitch API and significantly speeds up the tests.

@ColeWalker
Copy link
Owner Author

User-subscriber link still hits twitch api. https://d-fischer.github.io/twitch/reference/classes/HelixSubscription.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working high priority testing typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix slow auth tests CodeItQuick/twitch-graphql
2 participants
@CodeItQuick @ColeWalker