Initial implementation #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColinKennedy
force-pushed
the
add_comment_support_003
branch
from
f4c8240 to
1670290
Compare
Added WIP test Got tests to pass Got more tests to pass Got more tests to pass Got tests to pass Fixed unittests Added missing instruction offset information Added more tests Updated Cargo.toml Added WIP highlight unittests Added extra code location code Added more tests Got all main (non highlight) unittests working Added WIP tests Added more tests Got tests to pass Got more tests to pass Added WIP test Fixed newlines Got more tests to pass Added WIP tests for comments Fixed unittest WIP unittest updates Removed unused code Added new test Added tests Got all tests to pass Added comment rule Added more tests Added WIP scanner.cc Added mising comment Got more tests to pass Added WIP test Got tests to pass Added WIP unittests Added WIP tests Fixed unittests Added new failing test Simplified a test Removed unused code Condensing some queries down Getting more tests to pass Changed the instruction parser to be more correct Added EOF checks, just in case Got unittests to pass Renamed existing variables Simplified rules Got all tests to pass Updated comment Added README.md Added missing screenshot Added check.sh Got all tests to pass Added fake, broken test Fixed test Removed test
ColinKennedy
force-pushed
the
add_comment_support_003
branch
from
1670290 to
ee8f14c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial implementation