Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not run PR linting if PR is not open #303

Closed
4 tasks done
redeboer opened this issue Mar 7, 2024 · 0 comments · Fixed by ComPWA/actions#65
Closed
4 tasks done

Do not run PR linting if PR is not open #303

redeboer opened this issue Mar 7, 2024 · 0 comments · Fixed by ComPWA/actions#65
Assignees
@redeboer
Labels
⚙️ Enhancement Improvements and optimizations of existing features

Comments

@redeboer
Copy link
Member

redeboer commented Mar 7, 2024 •
edited
Loading

Simply add

if: github.event.pull_request.state == 'open'

to each job under pr-linting.yaml.

Optionally, we can outsource the linting to ComPWA/actions/.github/workflows/pr-linting.yml if it is gets a workflow call.

Tasks
Beta Give feedback
  1. ENH: add --keep-pr-linting flag #304
    ⚙️ Enhancement
    redeboer
  2. ENH: make PR linting available as workflow call actions#64
    ✨ Feature
    redeboer
  3. ENH: only lint PRs if they are open actions#65
    ⚙️ Enhancement
    redeboer
  4. DX: outsource PR linting to ComPWA/actions #307
    🖱️ DX
    redeboer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redeboer redeboer

Labels
⚙️ Enhancement Improvements and optimizations of existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: only lint PRs if they are open ComPWA/actions
1 participant
@redeboer