Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run nbqa-isort before ruff pre-commit hook #394

Open
redeboer opened this issue Sep 25, 2024 · 0 comments · May be fixed by #402
Open

Run nbqa-isort before ruff pre-commit hook #394

redeboer opened this issue Sep 25, 2024 · 0 comments · May be fixed by #402
Assignees
@shenvitor @redeboer @Zeyna777 @grayson-helmholz
Labels
🐛 Bug Something isn't working ⚙️ Enhancement Improvements and optimizations of existing features
Milestone
0.4.2

Comments

@redeboer
Copy link
Member

Since #392, the nbqa-isort can move all import statements to the top. It would be better to run ruff after nbqa-isort has moved all hooks to the top, otherwise pre-commit has to run twice.
@redeboer redeboer added 🐛 Bug Something isn't working ⚙️ Enhancement Improvements and optimizations of existing features labels Sep 25, 2024
@redeboer redeboer added this to the 0.4.2 milestone Sep 25, 2024
@redeboer redeboer self-assigned this Sep 25, 2024
@redeboer redeboer linked a pull request Oct 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shenvitor shenvitor

@redeboer redeboer

@Zeyna777 Zeyna777

@grayson-helmholz grayson-helmholz

Labels
🐛 Bug Something isn't working ⚙️ Enhancement Improvements and optimizations of existing features
Projects
None yet
Milestone
0.4.2
Development

Successfully merging a pull request may close this issue.

ENH: run nbqa-isort before Ruff ComPWA/policy
4 participants
@shenvitor @redeboer @Zeyna777 @grayson-helmholz