Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: add --drop-empty-cells tag in pre-commmit hook #380

Merged
merged 1 commit into from
Aug 23, 2024
Merged

ENH: add --drop-empty-cells tag in pre-commmit hook #380

merged 1 commit into from
Aug 23, 2024

Conversation

shenvitor
Copy link
Member

@shenvitor shenvitor commented Aug 23, 2024 •
edited
Loading

@shenvitor shenvitor self-assigned this Aug 23, 2024
@redeboer redeboer changed the title DX: add --drop-empty-cells tag in pre-commmit hook ENH: add --drop-empty-cells tag in pre-commmit hook Aug 23, 2024
@shenvitor shenvitor added 📝 Docs Improvements or additions to documentation 🖱️ DX Improvements to the Developer Experience ⚙️ Enhancement Improvements and optimizations of existing features labels Aug 23, 2024
@redeboer redeboer self-requested a review August 23, 2024 09:37
@shenvitor shenvitor added 🔨 Maintenance Maintenance and upkeep improvements ✨ Feature New feature added to the package labels Aug 23, 2024
@redeboer redeboer removed 🔨 Maintenance Maintenance and upkeep improvements ✨ Feature New feature added to the package labels Aug 23, 2024
redeboer
redeboer approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with

  - repo: https://github.com/ComPWA/policy
    rev: df5e9533698d379907d6c69a6e327601f74ae320
    hooks:
      - id: check-dev-files

Works, thanks! 🎾

@redeboer redeboer merged commit ca6cdf0 into main Aug 23, 2024
34 of 36 checks passed
@redeboer redeboer deleted the nbstripout-remove-empty-cells branch August 23, 2024 09:41
@redeboer redeboer mentioned this pull request Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redeboer redeboer redeboer approved these changes

Assignees

@shenvitor shenvitor

Labels
📝 Docs Improvements or additions to documentation 🖱️ DX Improvements to the Developer Experience ⚙️ Enhancement Improvements and optimizations of existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove empty cells with nbstripout
2 participants
@shenvitor @redeboer