[nodeploy] Clean up tests

CominAtYou · Jun 5, 2024 · 8871e01 · 8871e01
1 parent 37b1212
commit 8871e01
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/test/java/com/cominatyou/RankTest.java b/src/test/java/com/cominatyou/RankTest.java
@@ -12,15 +12,16 @@
 
 public class RankTest {
     private static final int[] rankLevels = RankUtil.getRanklevels();
+    private static final int TOTAL_RANK_LEVEL_COUNT = 26;
 
     @Test
     public void ensureCorrectAmountOfRankLevels() {
-        assertEquals(26, rankLevels.length);
+        assertEquals(TOTAL_RANK_LEVEL_COUNT, rankLevels.length);
     }
 
     @Test
     public void ensureUniqueRankRoleIDs() {
-        final ArrayList<Long> seenIDs = new ArrayList<>(26);
+        final ArrayList<Long> seenIDs = new ArrayList<>(TOTAL_RANK_LEVEL_COUNT);
         for (final int i : rankLevels) {
             final Rank rank = RankUtil.getRankFromLevel(i);
             if (seenIDs.contains(rank.getId())) {
@@ -36,7 +37,7 @@ public void ensureUniqueRankRoleIDs() {
     public void ensureCorrectRankRoleIdFormat() {
         for (final int i : rankLevels) {
             final Rank rank = RankUtil.getRankFromLevel(i);
-            if (!String.valueOf(rank.getId()).matches("^[0-9]{17,19}$")) {
+            if (!String.valueOf(rank.getId()).matches("^[0-9]{17,}$")) {
                 fail(String.format("Level %d: ID %d is not a Discord snowflake!", i, rank.getId()));
             }
         }
@@ -54,14 +55,14 @@ public void ensureCorrectRankLevels() {
     public void ensureSortedRankLevels() {
         for (int i = 0; i < rankLevels.length - 1; i++) {
             if (rankLevels[i] > rankLevels[i + 1]) {
-                fail(String.format("Level %d: next level is %d, which is less a lower level", rankLevels[i], rankLevels[i + 1]));
+                fail(String.format("Level %d: next level is %d, which is a lower level", rankLevels[i], rankLevels[i + 1]));
             }
         }
     }
 
     @Test
     public void ensureUniqueRankNames() {
-        final ArrayList<String> seenNames = new ArrayList<>(26);
+        final ArrayList<String> seenNames = new ArrayList<>(TOTAL_RANK_LEVEL_COUNT);
         for (final int i : rankLevels) {
             final Rank rank = RankUtil.getRankFromLevel(i);
             if (seenNames.contains(rank.getName())) {