Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize paths to forward slashes before comparing #1984

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Seldaek
Copy link

@Seldaek Seldaek commented Jun 19, 2015

I experienced the issue at #1769 and this resolved it for me, basically removes the inconsistencies across paths, when config paths have forward slashes you tend to end up with mixed paths on windows like say c:/Foo\Bar/Baz. This is entirely equivalent to c:/Foo/Bar/Baz or c:\Foo\Bar\Baz to the filesystem, but not to an index check obviously since the strings are different.

Note that I don't really know ruby much so in case there is a cleaner way to normalize the paths please feel free to point me in the right direction, but I can confirm that it worked for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant